New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783173 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

compile failure on continuous mac64 trunk

Project Member Reported by ajha@chromium.org, Nov 9 2017

Issue description

compile failure on continuous mac64 trunk 

Build Path: 
 https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac64 trunk/builds/8322 

Log Path: 
 https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac64 trunk/builds/8322/steps/compile/logs/stdio 

Error:
FAILED: obj/remoting/host/main/host_main.o 
export DEVELOPER_DIR=/b/c/b/mac64_trunk/src/build/mac_files/Xcode.app;  ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/remoting/host/main/host_main.o.d -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -DCR_XCODE_VERSION=0832 -DCR_CLANG_REVISION=\"317263-3\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../.. -Igen -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -arch x86_64 -Wall -Werror -Wextra -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-tautological-unsigned-zero-compare -Wno-null-pointer-arithmetic -Wno-tautological-unsigned-enum-zero-compare -Wno-tautological-constant-compare -O2 -fno-omit-frame-pointer -gdwarf-2 -fno-standalone-debug -isysroot ../../build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -mmacosx-version-min=10.9.0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=c++14 -stdlib=libc++ -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -c ../../remoting/host/host_main.cc -o obj/remoting/host/main/host_main.o
In file included from ../../remoting/host/host_main.cc:22:
In file included from ../../mojo/edk/embedder/embedder.h:16:
In file included from ../../base/task_runner.h:12:
../../base/location.h:14:10: fatal error: 'base/debug/debugging_flags.h' file not found
#include "base/debug/debugging_flags.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
[177/43846] CC obj/chrome/installer/mac/third_party/xz/compress/vli_encoder.o
[178/43846] CC obj/chrome/installer/mac/third_party/xz/compress/index_encoder.o
[179/43846] CC obj/chrome/installer/mac/third_party/xz/compress/stream_encoder.o
[180/43846] CC obj/chrome/installer/mac/third_party/xz/common/index.o
[181/43846] CC obj/chrome/installer/mac/third_party/xz/compress/easy_encoder_memusage.o
[182/43846] CC obj/chrome/installer/mac/third_party/xz/compress/simple_encoder.o
[183/43846] CC obj/chrome/installer/mac/third_party/xz/decompress/filter_flags_decoder.o
[184/43846] CC obj/chrome/installer/mac/third_party/xz/decompress/block_buffer_decoder.o
[185/43846] ACTION //chrome/installer/mac:make_signers(//build/toolchain/mac:clang_x64)
[186/43846] CC obj/chrome/installer/mac/third_party/xz/compress/lz_encoder.o
[187/43846] ACTION //chrome/installer/mac/app:mac_installer_app_info_plist_merge(//build/toolchain/mac:clang_x64)
[188/43846] CC obj/chrome/installer/mac/third_party/xz/compress/lzma2_encoder.o
[189/43846] ACTION //chrome/common/extensions/api:api_schema_generator(//build/toolchain/mac:clang_x64)
[190/43846] ACTION //chrome/common/extensions/api:api_schema_generator(//build/toolchain/mac:clang_x64)
[191/43846] CXX obj/chrome/installer/mac/third_party/bsdiff/goobsdiff_sha1_adapter/sha1_adapter.o
[192/43846] CC obj/chrome/installer/mac/third_party/xz/decompress/alone_decoder.o
[193/43846] CC obj/chrome/installer/mac/third_party/xz/compress/lzma_encoder.o
[194/43846] CC obj/chrome/installer/mac/third_party/xz/compress/lz_encoder_mf.o
[195/43846] CC obj/chrome/installer/mac/third_party/xz/compress/lzma_encoder_optimum_normal.o
[196/43846] CXX obj/chrome/installer/mac/third_party/bsdiff/goobsdiff_sha1_adapter/sha1.o
[197/43846] OBJC obj/chrome/installer/mac/app/mac_installer_base/Unpacker.o
[198/43846] ACTION //chrome/installer/mac/app:mac_installer_xibs_compile_ibtool(//build/toolchain/mac:clang_x64)
[199/43846] ACTION //chrome/common/extensions/api:api_schema_generator(//build/toolchain/mac:clang_x64)
[200/43846] ACTION //chrome/common/extensions/api:api_registration_bundle_generator_registration(//build/toolchain/mac:clang_x64)
[201/43846] ACTION //chrome/common/extensions/api:api_bundle_generator_schema(//build/toolchain/mac:clang_x64)
ninja: build stopped: subcommand failed.
step returned non-zero exit code: 1


Suspected CL: None of the CLs from the Blamelist looks related.

This looks exactly the same as Issue 762170.

Please take a look. 
Thanks

 
Labels: -Pri-1 Pri-2
Owner: brettw@chromium.org
Status: Assigned (was: Untriaged)
This issue has existed for quite a while. A previous report (which was closed without action):
https://bugs.chromium.org/p/chromium/issues/detail?id=762170

debugging_flags is a generated file, I bet there are some missing deps so it might not exist yet when location.h needs it.

Brett: would you please take a look? Thanks!

Cc: jamiewa...@chromium.org brettw@chromium.org
Labels: -Restrict-View-Google -Sheriff-Chromium
Owner: garykac@chromium.org
This is a problem in //remoting/host, which has no GN dependency on //mojo/edk/embedder whatsoever. Through the dependency chain into //remoting/host all the right dependencies are being listed as public_deps, so it's just at the top level of the dependency chain that there's a problem. garykac@/jamiewalch@, can you fix this by adding //mojo/edk/embedder as a dependency of the relevant targets? //remoting/host/BUILD.gn is kind of tangled; it seems to have multiple targets that build //remoting/host/host_main.cc.

Removing Sheriff-Chromium as this isn't a sheriffing issue at this point.
Owner: jamiewa...@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/219dad3023887d05255aa76d52983ead103968d2

commit 219dad3023887d05255aa76d52983ead103968d2
Author: Jamie Walch <jamiewalch@chromium.org>
Date: Mon Nov 13 22:17:48 2017

Add //mojo/edk/embedder:headers as a dependency for the multi-process host.

Bug:  783173 
Change-Id: I2bcf961155fab34a9a58865ca17ebe28876bab10
Reviewed-on: https://chromium-review.googlesource.com/764118
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Zijie He <zijiehe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516078}
[modify] https://crrev.com/219dad3023887d05255aa76d52983ead103968d2/remoting/host/BUILD.gn
[modify] https://crrev.com/219dad3023887d05255aa76d52983ead103968d2/remoting/host/host_main.cc

Status: Fixed (was: Assigned)

Sign in to add a comment