New issue
Advanced search Search tips

Issue 783169 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Nov 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

ContentSuggestionsTestCase/testReadingListOpenNewTab fails on iOS 11 iPhone 7 bots

Project Member Reported by sdefresne@chromium.org, Nov 9 2017 
See https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone11-device-x64/builds/942

ContentSuggestionsTestCase/testReadingListOpenNewTab:
[1109/054014.447338:WARNING:embedded_test_server.cc(228)] Request not handled. Returning 404: /favicon.ico
../../ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm:565: error: -[ContentSuggestionsTestCase testReadingListOpenNewTab] : Exception: AssertionFailedException
Exception Name: AssertionFailedException
Exception Reason: ((testing::WaitUntilConditionOrTimeout( testing::kWaitForUIElementTimeout, condition)) is true) failed
Exception Details: Collection view not visible
Bundle ID: com.google.gtest.ios-chrome-ui-egtests
Stack Trace: (
	0   EarlGrey                            0x000000010522a158 -[GREYDefaultFailureHandler handleException:details:] + 904
	1   ios_chrome_ui_egtests               0x00000001011637f8 -[ContentSuggestionsTestCase testReadingListOpenNewTab] + 1088
	2   CoreFoundation                      0x0000000185af76a0 <redacted> + 144
	3   CoreFoundation                      0x00000001859d6820 <redacted> + 292
	4   EarlGrey                            0x0000000105219a7c -[GREYTestCaseInvocation invoke] + 92
	5   XCTest                              0x00000001050c40a8 __24-[XCTestCase invokeTest]_block_invoke.275 + 48
	6   XCTest                              0x0000000105110f08 -[XCTMemoryChecker _assertInvalidObjectsDeallocatedAfterScope:] + 56
	7   XCTest                              0x00000001050c3e58 __24-[XCTestCase invokeTest]_block_invoke + 680
	8   XCTest                              0x0000000105109780 -[XCUITestContext performInScope:] + 208
	9   XCTest                              0x00000001050c3ba0 -[XCTestCase invokeTest] + 136
	10  EarlGrey                            0x0000000105210848 -[XCTestCase(GREYAdditions) grey_invokeTest] + 472
	11  XCTest                              0x00000001050c4c78 __26-[XCTestCase performTest:]_block_invoke.382 + 48
	12  XCTest                              0x000000010510e778 +[XCTContext runInContextForTestCase:block:] + 164
	13  XCTest                              0x00000001050c4674 -[XCTestCase performTest:] + 596
	14  XCTest                              0x00000001050c0868 __27-[XCTestSuite performTest:]_block_invoke + 288
	15  XCTest                              0x00000001050c0290 -[XCTestSuite _performProtectedSectionForTest:testSection:] + 44
	16  XCTest                              0x00000001050c04a0 -[XCTestSuite performTest:] + 236
	17  XCTest                              0x00000001050c0868 __27-[XCTestSuite performTest:]_block_invoke + 288
	18  XCTest                              0x00000001050c0290 -[XCTestSuite _performProtectedSectionForTest:testSection:] + 44
	19  XCTest                              0x00000001050c04a0 -[XCTestSuite performTest:] + 236
	20  XCTest                              0x00000001050c0868 __27-[XCTestSuite performTest:]_block_invoke + 288
	21  XCTest                              0x00000001050c0290 -[XCTestSuite _performProtectedSectionForTest:testSection:] + 44
	22  XCTest                              0x00000001050c04a0 -[XCTestSuite performTest:] + 236
	23  XCTest                              0x0000000105117f5c __44-[XCTTestRunSession runTestsAndReturnError:]_block_invoke + 44
	24  XCTest                              0x00000001050d33e8 -[XCTestObservationCenter _observeTestExecutionForBlock:] + 420
	25  XCTest                              0x0000000105117dd8 -[XCTTestRunSession runTestsAndReturnError:] + 292
	26  XCTest                              0x00000001050afed0 -[XCTestDriver runTestsAndReturnError:] + 312
	27  XCTest                              0x000000010510d920 _XCTestMain + 620
	28  CoreFoundation                      0x0000000185a9816c <redacted> + 20
	29  CoreFoundation                      0x0000000185a97a3c <redacted> + 288
	30  CoreFoundation                      0x0000000185a9574c <redacted> + 1068
	31  CoreFoundation                      0x00000001859b62d8 CFRunLoopRunSpecific + 436
	32  GraphicsServices                    0x000000018783cf84 GSEventRunModal + 100
	33  UIKit                               0x000000018eee827c UIApplicationMain + 208
	34  ios_chrome_ui_egtests               0x0000000100a0f89c main + 604
	35  libdyld.dylib                       0x00000001854da56c <redacted> + 4
)

gambard, can you investigate?
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7bb9e7c1e3b3715334654540915d5d89d8d692e

commit a7bb9e7c1e3b3715334654540915d5d89d8d692e
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Nov 10 10:56:01 2017

Add delay on EG test

This CL adds a 0.5s delay on the ContentSuggestions tests to allow the
New Tab Opened animation to complete. This is needed as the animation
is a CAAnimations, EG has trouble synchronizing on it.
Using a loop to check if the first tab has came back does not work as
the steps inside the loop is too short for the animation to have time
to continue. Using it froze the animation.

Bug:  783169 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I71e247d9e373df96f601e613eb0bec83704ac09a
Reviewed-on: https://chromium-review.googlesource.com/763408
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515525}
[modify] https://crrev.com/a7bb9e7c1e3b3715334654540915d5d89d8d692e/ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm

Comment 2 by gambard@chromium.org, Nov 10 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment