New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783164 link

Starred by 22 users

Issue metadata

Status: Duplicate
Merged: issue 819276
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Power button in tablet mode won't put display to sleep

Reported by robby.n....@gmail.com, Nov 9 2017

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 9901.54.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.74 Safari/537.36
Platform: 9901.54.0 (Official Build) stable-channel eve

Steps to reproduce the problem:
1. Put Pixelbook in tablet mode 
2. Push power button

What is the expected behavior?
On other convertible Chromebooks, this function would immediately put the screen to sleep and lock the Chromebook.

What went wrong?
The power button continues to behave as if the device is in laptop mode where holding it for a few seconds locks the device and a few more seconds powers down.  This is not how it should work any longer.

Did this work before? N/A 

Chrome version: 62.0.3202.74  Channel: n/a
OS Version: 9901.54.0
Flash Version: 

We have a Samsung Chromebook Pro that is on Chrome OS 64 in dev mode and this feature works fine on it.
 

Comment 1 by dymp...@gmail.com, Nov 9 2017

CBC-RS/TC-watchlist
Cc: derat@chromium.org
Components: -UI UI>Input>KeyboardShortcuts OS>Kernel>Power
Owner: warx@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 3 by warx@chromium.org, Nov 10 2017

Status: WontFix (was: Assigned)
It is intended behavior on pixelbook. Will screen be turned off 3s after you lock the screen by power button?
Just my two cents, but it seems odd that I have to explicitly lock my device in tablet mode, but in laptop mode, I can just close my screen and reopen and I don't have to log back in.

Comment 5 by derat@chromium.org, Nov 11 2017

#4: Sorry, I don't understand what you mean. I don't think the screen should be locked in either case unless you have the "Show lock screen when waking from sleep" setting enabled. Are you seeing different behavior?
On the Samsung CB Pro, the power button turns off the screen and locks immediately upon being pressed.  This is a feature that was added in March 2017.  I just checked the Samsung and it works as expected.

Comment 7 by derat@chromium.org, Nov 11 2017

This bug report was about the Pixelbook's behavior differing from other convertible Chromebooks, which is intentional.

If you're seeing behavior that seems incorrect on a Chromebook Pro, please file a separate bug about it -- it's not the same as what's being discussed here.
#5. On my pixelbook, if I hit power button in tablet mode, it locks my device even if I have Show lock screen when waking up disabled. I'm on beta channel. 

Comment 9 by derat@chromium.org, Nov 12 2017

#8: Yes, that's the intended behavior on Pixelbooks. The power button behaves similarly to those on non-convertible Chromebooks, i.e. it first locks the screen and then shuts the system down.
Labels: Hotlist-ConOps
Why would you change the behavior on all existing convertibles (to a way that makes sense BTW) and then release your flagship with the old antiquated system? Also, why would you have it so that the pixelbook is different from all other convertibles? This really makes no sense. 
hire someone that will
powerbutton for all chromebooks SHOULD option:
A. Turn off display "allows services to run in background ~ like downloading a file"
B. Go to sleep "conserve battery" 

User can still disable lockscreen for faster access from sleep mode.

Comment 14 by pau...@gmail.com, Feb 12 2018

Yes, make it a user-selectable option. If the developers disagree with the majority of users on how the power button should work, then make our preference opt-in. 

It's very frustrating to have no way of turning off the screen in tablet mode without shutting off the machine.

Comment 15 by derat@chromium.org, Feb 12 2018

> It's very frustrating to have no way of turning off the screen
> in tablet mode without shutting off the machine.

This is already supported on the Pixelbook. Hold the power button for a second until the screen is locked and then let go of the power button. The screen will turn off three seconds later.
@derat #15

This isn't true. This locks the device and you have to enter a password to unlock it which is very cumbersome. It isn't the same as other convertibles where it just turns the display on and off.

I feel inclined to ask why this one convertible was singled out to behave differently than all other convertibles? It is very counterintuitive and user hostile. Honestly it feels like there is a contingent at Google who simply prefer this behavior and that is why it was chosen over the behavior used in every other Chromebook convertible I'm aware of.

Comment 17 by derat@chromium.org, Feb 14 2018

Status: Untriaged (was: WontFix)
#16: Thanks for elaborating. It's true that this locks the screen, which is non-ideal for users who don't have automatic screen lock enabled.

This is something that we're aware of and hope to address soon in an update to the behavior of the power button. I'll dupe this bug into one tracking that work once the design is finished.
Cc: -derat@chromium.org warx@chromium.org
Owner: derat@chromium.org
Status: Assigned (was: Untriaged)
On Chrome 67.0.3382.0 and later (which should be present on the dev channel now), there's a new experimental "Enable mode-specific power button behavior." setting at chrome://flags that makes tapping the power button turn the screen off on convertible Chromebooks (including the Pixelbook) while in tablet mode.

Note that the power button behavior is being reworked more broadly for 67 and some aspects of the current UI are still being changed.
Project Member

Comment 20 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd33ca87c35e2ee3cdf19629fbd1ee38c2958520

commit fd33ca87c35e2ee3cdf19629fbd1ee38c2958520
Author: Daniel Erat <derat@chromium.org>
Date: Tue Apr 17 19:18:44 2018

chromeos: Enable mode-specific power button behavior.

Enable mode-specific power button behavior by default. In
short, tapping the power button turns the display off on
devices that are in tablet mode but is ignored on devices
that are in laptop mode.

Bug:  819276 ,  783164 
Change-Id: Ic658e034366a32066940c647a73b8c61ecec2840
Reviewed-on: https://chromium-review.googlesource.com/1014486
Commit-Queue: Dan Erat <derat@chromium.org>
Reviewed-by: Min Chen <minch@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#551427}
[modify] https://crrev.com/fd33ca87c35e2ee3cdf19629fbd1ee38c2958520/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/fd33ca87c35e2ee3cdf19629fbd1ee38c2958520/ash/lock_screen_action/lock_screen_note_display_state_handler_unittest.cc
[modify] https://crrev.com/fd33ca87c35e2ee3cdf19629fbd1ee38c2958520/ash/public/cpp/ash_features.cc
[modify] https://crrev.com/fd33ca87c35e2ee3cdf19629fbd1ee38c2958520/ash/system/power/power_button_controller_unittest.cc

Project Member

Comment 21 by bugdroid1@chromium.org, Apr 18 2018

Labels: merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c4acd68284aaedac09e49df38abec5e644c0f96

commit 9c4acd68284aaedac09e49df38abec5e644c0f96
Author: Daniel Erat <derat@chromium.org>
Date: Wed Apr 18 20:15:29 2018

chromeos: Enable mode-specific power button behavior.

Enable mode-specific power button behavior by default. In
short, tapping the power button turns the display off on
devices that are in tablet mode but is ignored on devices
that are in laptop mode.

Bug:  819276 ,  783164 
Change-Id: Ic658e034366a32066940c647a73b8c61ecec2840
Reviewed-on: https://chromium-review.googlesource.com/1014486
Commit-Queue: Dan Erat <derat@chromium.org>
Reviewed-by: Min Chen <minch@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#551427}(cherry picked from commit fd33ca87c35e2ee3cdf19629fbd1ee38c2958520)
Reviewed-on: https://chromium-review.googlesource.com/1017662
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#98}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/9c4acd68284aaedac09e49df38abec5e644c0f96/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/9c4acd68284aaedac09e49df38abec5e644c0f96/ash/lock_screen_action/lock_screen_note_display_state_handler_unittest.cc
[modify] https://crrev.com/9c4acd68284aaedac09e49df38abec5e644c0f96/ash/public/cpp/ash_features.cc
[modify] https://crrev.com/9c4acd68284aaedac09e49df38abec5e644c0f96/ash/system/power/power_button_controller_unittest.cc

#17: Thank you for your thoughtful reply.

#19: Thank you for the update. I am glad to see there will soon be an option to change the behavior.

Finally, Thank you to the entire chromium team for listing to user feedback and bringing about a real change for the users. I'm fine with it being a flag. I'm a power user and can find the hidden settings, I just want the options. 

*cough* are you listening Android team *cough*

In short, this is one of the reasons I've grown to love Chromebooks despite what many say about the limited, but soon to be changing, capability.

Comment 23 by derat@chromium.org, Apr 27 2018

Mergedinto: 819276
Status: Duplicate (was: Assigned)
No problem!

Just as a note, this will be on by default (i.e. no setting) in M67, which is expected to go to the beta channel soon and to the stable channel sometime around the beginning of June.

I'm duping this bug into the one that tracked that work.

Sign in to add a comment