I started a proposal to automatically skip @ChromeHome tests on tablets to avoid problems like issue 782868 Doc: https://docs.google.com/a/google.com/document/d/1WQgShnrPWnNeMKa6DaZH5Yfd6GDWSKGwW8agYBwK8og Please have a look.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67a6d728918ef36565ddadb816ff8ebdf9d2dacb commit 67a6d728918ef36565ddadb816ff8ebdf9d2dacb Author: Nicolas Dossou-gbete <dgn@chromium.org> Date: Fri Dec 01 02:07:55 2017 🔬 Add utility for processing annotations in tests Introduces AnnotationProcessingUtils, which provides: - AnnotationExtractor, a class allowing to retrieve one or many annotations in reverse declaration order from a class or a test description - AnnotationProcessor, a rule to simplify the use of the above extractor in the context of tests (here used as parent for @Features rule). - Utility methods to simplify the use of the above extractor in other contexts (here used in SkipChecks) Bug: 783160 ,754778 Change-Id: I8ca0793e1229c6268266c75791a44615b8f93f57 Reviewed-on: https://chromium-review.googlesource.com/789192 Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#520789} [modify] https://crrev.com/67a6d728918ef36565ddadb816ff8ebdf9d2dacb/base/BUILD.gn [add] https://crrev.com/67a6d728918ef36565ddadb816ff8ebdf9d2dacb/base/test/android/javatests/src/org/chromium/base/test/util/AnnotationProcessingUtils.java [delete] https://crrev.com/d756c2dfa56141b3970cd836fb0a39d6872ca0e6/base/test/android/javatests/src/org/chromium/base/test/util/AnnotationProcessor.java [add] https://crrev.com/67a6d728918ef36565ddadb816ff8ebdf9d2dacb/base/test/android/javatests/src/org/chromium/base/test/util/AnnotationRule.java [modify] https://crrev.com/67a6d728918ef36565ddadb816ff8ebdf9d2dacb/base/test/android/javatests/src/org/chromium/base/test/util/DisableIfSkipCheck.java [modify] https://crrev.com/67a6d728918ef36565ddadb816ff8ebdf9d2dacb/base/test/android/javatests/src/org/chromium/base/test/util/MinAndroidSdkLevelSkipCheck.java [modify] https://crrev.com/67a6d728918ef36565ddadb816ff8ebdf9d2dacb/base/test/android/javatests/src/org/chromium/base/test/util/RestrictionSkipCheck.java [modify] https://crrev.com/67a6d728918ef36565ddadb816ff8ebdf9d2dacb/base/test/android/javatests/src/org/chromium/base/test/util/SkipCheck.java [add] https://crrev.com/67a6d728918ef36565ddadb816ff8ebdf9d2dacb/base/test/android/junit/src/org/chromium/base/test/util/AnnotationProcessingUtilsTest.java [modify] https://crrev.com/67a6d728918ef36565ddadb816ff8ebdf9d2dacb/base/test/android/junit/src/org/chromium/base/test/util/SkipCheckTest.java [modify] https://crrev.com/67a6d728918ef36565ddadb816ff8ebdf9d2dacb/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/ChromeHome.java [modify] https://crrev.com/67a6d728918ef36565ddadb816ff8ebdf9d2dacb/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/Features.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ef4e359eed63ac369c7f95edcb2d42d646f4fff commit 6ef4e359eed63ac369c7f95edcb2d42d646f4fff Author: Nicolas Dossou-gbete <dgn@chromium.org> Date: Tue Dec 05 11:22:01 2017 🔬 Improve @ChromeHome usability in unit and instrumentation tests - Introduces @ChromeHome.Enable and @ChromeHome.Disable - @ChromeHome.Enable automatically causes the test test to be skipped when running on a tablet - @ChromeHome now works for unit tests, ensures the cached state is reset between tests. The plain @ChromeHome should eventually be removed in favour of the dedicated annotations, that will happen in a subsequent cleanup patch. Bug: 783160 ,754778 Change-Id: I60c69c2fb97a08aa1d0bcf533a8378cbbc1a548b Reviewed-on: https://chromium-review.googlesource.com/796672 Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#521664} [modify] https://crrev.com/6ef4e359eed63ac369c7f95edcb2d42d646f4fff/chrome/android/javatests/src/org/chromium/chrome/browser/FeaturesAnnotationsTest.java [modify] https://crrev.com/6ef4e359eed63ac369c7f95edcb2d42d646f4fff/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java [modify] https://crrev.com/6ef4e359eed63ac369c7f95edcb2d42d646f4fff/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupUnitTest.java [modify] https://crrev.com/6ef4e359eed63ac369c7f95edcb2d42d646f4fff/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/ChromeHome.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b439253ed579495f6306500270c169721422d57d commit b439253ed579495f6306500270c169721422d57d Author: Nicolas Dossou-gbete <dgn@chromium.org> Date: Fri Dec 15 15:19:07 2017 🔬 Cleanup @ChromeHome usage Simple cleanup change. Replaces some uses of @CommandLineFlags with @ChromeHome and @EnableFeatures, and removes unused code from @ChromeHome. Bug: 783160 Change-Id: I508ea74b923360fde65eb2e247c727aab825f8a9 Reviewed-on: https://chromium-review.googlesource.com/788214 Reviewed-by: Peter Conn <peconn@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#524386} [modify] https://crrev.com/b439253ed579495f6306500270c169721422d57d/chrome/android/javatests/src/org/chromium/chrome/browser/FeaturesAnnotationsTest.java [modify] https://crrev.com/b439253ed579495f6306500270c169721422d57d/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/AllDismissedItemTest.java [modify] https://crrev.com/b439253ed579495f6306500270c169721422d57d/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/ContextualSuggestionsTest.java [modify] https://crrev.com/b439253ed579495f6306500270c169721422d57d/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/TileGridLayoutTest.java [modify] https://crrev.com/b439253ed579495f6306500270c169721422d57d/chrome/test/android/javatests/src/org/chromium/chrome/test/BottomSheetTestRule.java [modify] https://crrev.com/b439253ed579495f6306500270c169721422d57d/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/ChromeHome.java
Comment 1 by bugdroid1@chromium.org
, Dec 1 2017