Issue metadata
Sign in to add a comment
|
--render-results-directory no longer does anything |
||||||||||||||||||||
Issue description--render-results-directory DIRECTORY used to copy the results of render tests to that directory after running Instrumentation tests. I think you accidentally removed this functionality when you added support for local output. I'm not sure whether it would be worth readding/fixing since we can now use the --local-output flag to get the results, but in that case we should remove it from the args and InstrumentationTestInstance.
,
Nov 9 2017
Really? I've been getting local-output just by running: /out_chrome/Debug/bin/run_chrome_public_test_apk -f '*NewTabPageTest*' --local-output (Also, printing the output directory at the end of a test run would make --local-output a lot easier to use).
,
Nov 9 2017
oh, I was thinking of local result details, which does currently require both: https://codesearch.chromium.org/chromium/src/build/android/test_runner.py?rcl=7c01885f48c7a94b731f0794d635f784eb12e135&l=906
,
Nov 10 2017
on review: https://chromium-review.googlesource.com/c/chromium/src/+/763989
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/438db0fd1140c7a5af912a28815353e5d4379dc4 commit 438db0fd1140c7a5af912a28815353e5d4379dc4 Author: John Budorick <jbudorick@chromium.org> Date: Thu Nov 16 20:36:13 2017 [android] Always save result details on --local-output. Bug: 783158 Change-Id: I83f27f465828f59fa8a213b7273ab430934f5499 Reviewed-on: https://chromium-review.googlesource.com/763989 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by: Zhiling Huang <hzl@chromium.org> Cr-Commit-Position: refs/heads/master@{#517172} [modify] https://crrev.com/438db0fd1140c7a5af912a28815353e5d4379dc4/build/android/pylib/instrumentation/instrumentation_test_instance.py [modify] https://crrev.com/438db0fd1140c7a5af912a28815353e5d4379dc4/build/android/test_runner.py
,
Nov 17 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by jbudorick@chromium.org
, Nov 9 2017