PlatformSensorFusion must remove its outdated configurations from sources |
||
Issue descriptionPlatformSensorFusion adds new configurations to its sources at each StartSensor() call, however the previous configurations are not removed and kept until PlatformSensorFusion::StopSensor() is called. The side effect of this issue is that if PlatformSensorFusion::StartSensor() is first called with frequency==60 and then with frequency==30, the source sensor will still deliver readings at 60Hz rate. The PlatformSensorFusion must keep only one active configuration for a source sensor at a time.
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f4d0c5f3c58ac83371aa344aad6f0641e315a2e commit 4f4d0c5f3c58ac83371aa344aad6f0641e315a2e Author: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Date: Fri Nov 10 22:04:12 2017 [sensors] PlatformSensorFusion must keep only one active configuration for its sources Before this change, PlatformSensorFusion added new configurations to its sources sensors at each StartSensor() call, however the previous configurations were not removed and were kept until PlatformSensorFusion::StopSensor() was called. It caused picking wrong configuration for the source sensors. Also this patch fixes handling of a single source sensor failure at PlatformSensorFusion::StartSensor(). Bug: 783156 Change-Id: Ia91b9ea9fc333c7f22af0c6a310deba3f9bf8079 Reviewed-on: https://chromium-review.googlesource.com/758865 Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Jun Cai <juncai@chromium.org> Reviewed-by: Alexander Shalamov <alexander.shalamov@intel.com> Cr-Commit-Position: refs/heads/master@{#515706} [modify] https://crrev.com/4f4d0c5f3c58ac83371aa344aad6f0641e315a2e/services/device/generic_sensor/fake_platform_sensor_and_provider.cc [modify] https://crrev.com/4f4d0c5f3c58ac83371aa344aad6f0641e315a2e/services/device/generic_sensor/fake_platform_sensor_and_provider.h [modify] https://crrev.com/4f4d0c5f3c58ac83371aa344aad6f0641e315a2e/services/device/generic_sensor/generic_sensor_service_unittest.cc [modify] https://crrev.com/4f4d0c5f3c58ac83371aa344aad6f0641e315a2e/services/device/generic_sensor/platform_sensor.cc [modify] https://crrev.com/4f4d0c5f3c58ac83371aa344aad6f0641e315a2e/services/device/generic_sensor/platform_sensor.h [modify] https://crrev.com/4f4d0c5f3c58ac83371aa344aad6f0641e315a2e/services/device/generic_sensor/platform_sensor_and_provider_unittest.cc [modify] https://crrev.com/4f4d0c5f3c58ac83371aa344aad6f0641e315a2e/services/device/generic_sensor/platform_sensor_fusion.cc [modify] https://crrev.com/4f4d0c5f3c58ac83371aa344aad6f0641e315a2e/services/device/generic_sensor/platform_sensor_fusion_unittest.cc
,
Nov 14 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by mikhail....@intel.com
, Nov 9 2017