New issue
Advanced search Search tips

Issue 783152 link

Starred by 1 user
Status: Fixed
Owner:
tangltom@chromium.org
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 3
Type: Feature



Sign in to add a comment

Refactor EditableProfilePhoto for DICE UI

Project Member Reported by tangltom@chromium.org, Nov 9 2017 
The class EditableProfilePhoto should be moved out of profile_chooser_view.cc, refactored and renamed to BadgedProfilePhoto.

This work has to be done for the preparation of DICE UI.

Mocks for the DICE UI and the badged profile photo:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZdEftkBvH82b/files/MCHtA7U1iMGr6xILbLjJAjB360-KKhy_Qu8
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5377b50fb7a964e53de34eacc874b9e42e2a72c4

commit 5377b50fb7a964e53de34eacc874b9e42e2a72c4
Author: Thomas Tangl <tangltom@chromium.org>
Date: Thu Nov 16 17:17:20 2017

Replace EditableProfilePhoto with BadgedProfilePhoto

The class EditableProfilePhoto is replaced with BadgedProfilePhoto because
the editable-option has been dropped from that class. The class
is moved to a separate file, so it is easier to maintain and extend
(which will happen in the implementation for the DICe UI).

Bug:  783152 
Change-Id: I25fb7b1f3bf9f168ca23a90390365b13679c4eb6
Reviewed-on: https://chromium-review.googlesource.com/725293
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517112}
[modify] https://crrev.com/5377b50fb7a964e53de34eacc874b9e42e2a72c4/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/5377b50fb7a964e53de34eacc874b9e42e2a72c4/chrome/browser/ui/views/profiles/badged_profile_photo.cc
[add] https://crrev.com/5377b50fb7a964e53de34eacc874b9e42e2a72c4/chrome/browser/ui/views/profiles/badged_profile_photo.h
[modify] https://crrev.com/5377b50fb7a964e53de34eacc874b9e42e2a72c4/chrome/browser/ui/views/profiles/profile_chooser_view.cc

Comment 2 by tangltom@chromium.org, Jan 29 2018

Status: Fixed (was: Started)
►

Sign in to add a comment