Chromium doesn't compile via icecc |
||
Issue descriptionChrome Version: 64.0.3253.3 OS: Linux We use icecc to speed up compilation in our project. After this change: https://swiftshader-review.googlesource.com/12308 chromium doesn't compile via icecc as __has_include(<atomic>) is never expanded to 0 or 1 on icecc host and file <atomic> is not being included. My guess is that icecc host gets partially expanded code and it's not being passed by preprocessor again on the host side so condition #if __has_include(<atomic>) (expanded from #if USE_STD_ATOMIC) is never fulfilled.
,
Nov 10 2017
The following revision refers to this bug: https://swiftshader.googlesource.com/SwiftShader.git/+/d27cdd568f59afcb24726fc3e9d97762c6decb8b commit d27cdd568f59afcb24726fc3e9d97762c6decb8b Author: Cezary Kulakowski <ckulakowski@opera.com> Date: Fri Nov 10 09:09:06 2017 Don't use macro expressions in another macro We use icecc to speed up compilation in our project. After this change https://swiftshader-review.googlesource.com/12308 chromium doesn't compile via icecc as __has_include(<atomic>) is never expanded to 0 or 1 on icecc host and file <atomic> is not being included. My guess is that icecc host gets partially expanded code and it's not being passed by preprocessor again so condition #if __has_include(<atomic>) (expanded from #if USE_STD_ATOMIC) is never fulfilled. Bug: chromium:783135 Change-Id: I09cf120c399a794a15dec05d6edd74c7848fc53a Reviewed-on: https://swiftshader-review.googlesource.com/13588 Reviewed-by: Nicolas Capens <nicolascapens@google.com> Tested-by: Cezary Kulakowski <ckulakowski@opera.com> [modify] https://crrev.com/d27cdd568f59afcb24726fc3e9d97762c6decb8b/src/Common/Thread.hpp
,
Nov 12 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by ckulakow...@opera.com
, Nov 9 2017