New issue
Advanced search Search tips

Issue 783130 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

cryptohomed startup hanging on VPD read

Project Member Reported by mnissler@chromium.org, Nov 9 2017

Issue description

A recent bootperf chart shows that cryptohomed startup is apparently blocked 3.5 seconds on flashrom, almost certainly due to this line in cryptohomed.conf:

  (vpd -g stable_device_secret_DO_NOT_SHARE || printf '') >$ABE_DATA_FILE

The problem is that this access flash directly instead of using the VPD cache. That line should likely be changed to:

  (vpd_get_value_DO_NOT_SHARE || printf '') >$ABE_DATA_FILE

Assigning to drcrash who authored this in https://chromium.git.corp.google.com/chromiumos/platform2/+/1a538e150d8ec21d9c5b572ecfb66669162ce30d/cryptohome/init/cryptohomed.conf
 
Shouldn't that be

(vpd_get_value stable_device_secret_DO_NOT_SHARE || printf '')

?
Owner: drcrash@chromium.org
Re comment #1: Correct, sorry for screwing this up.

Owner=drcrash for realz.
Cc: drcrash@chromium.org
Labels: M-64
Owner: jorgelo@chromium.org
Status: Started (was: Untriaged)
CL at https://chromium-review.googlesource.com/c/chromiumos/platform2/+/760486
Status: Fixed (was: Started)
Fixed by https://chromium-review.git.corp.google.com/c/chromiumos/platform2/+/1022078.

Sign in to add a comment