New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783119 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

CHECK failure: nof_elements <= array_length in objects-debug.cc

Project Member Reported by ClusterFuzz, Nov 9 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4865789311320064

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  nof_elements <= array_length in objects-debug.cc
  v8::internal::JSArray::JSArrayVerify
  v8::internal::Object::ObjectVerify
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=48861:48862

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4865789311320064

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Cc: bmeu...@chromium.org
Owner: danno@chromium.org
Status: Assigned (was: Untriaged)
Regression range points to b590679496e829fd2f88ba4494072f0196c979de. Reproduces on tip-of-tree, not that it requires --verify-heap to reproduce.
Project Member

Comment 2 by ClusterFuzz, Nov 9 2017

Components: Blink>JavaScript>GC
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 9 2017

Labels: Pri-1
Labels: Security_Impact-Head M-64
mstarzinger: for these --verify-heap bugs, is that the bug requires --verify-heap to reproduce easily, or the bug just isn't reachable without --verify-heap? (i.e. should these be Security_Impact-None because the buggy code is disabled by default?)
Cc: est...@chromium.org
Emily, --verify-heap just makes things easier to reproduce (think of it like sanitizer vs normal builds), and bug is valid in production builds even without --verify-heap
Project Member

Comment 7 by sheriffbot@chromium.org, Nov 10 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/cecbe26bca0ee70438e45bd757283aa6400d6625

commit cecbe26bca0ee70438e45bd757283aa6400d6625
Author: Daniel Clifford <danno@chromium.org>
Date: Mon Nov 13 11:21:40 2017

Fix index bug in splicing dictionary element arrays

Bug:  chromium:783119 
Change-Id: I617db4f6740fb2cfe036ccf162a12aa2bac28e86
Reviewed-on: https://chromium-review.googlesource.com/763460
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Daniel Clifford <danno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49320}
[modify] https://crrev.com/cecbe26bca0ee70438e45bd757283aa6400d6625/src/elements.cc
[add] https://crrev.com/cecbe26bca0ee70438e45bd757283aa6400d6625/test/mjsunit/regress/regress-783119.js

Project Member

Comment 9 by ClusterFuzz, Nov 14 2017

ClusterFuzz has detected this issue as fixed in range 49319:49320.

Detailed report: https://clusterfuzz.com/testcase?key=4865789311320064

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  nof_elements <= array_length in objects-debug.cc
  v8::internal::JSArray::JSArrayVerify
  v8::internal::Object::ObjectVerify
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=48861:48862
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=49319:49320

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4865789311320064

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Nov 14 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4865789311320064 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by sheriffbot@chromium.org, Nov 14 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 12 by sheriffbot@chromium.org, Feb 20 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head -M-64 M-65 Security_Impact-Stable
Labels: -ReleaseBlock-Stable

Sign in to add a comment