timberslide starting too early during boot? |
||||
Issue descriptionA recent bootchart shows timberslide starting pretty early during boot: https://drive.google.com/open?id=1mMrr-K_9d5Mh95YG8UBOEkk0YWXijwNT timberslide.conf configures it to start at boot-services, which I don't see a good reason for? The general rule is that we should only start stuff that's needed for the login screen, anything else should hang of the system-services marker. We should either move this later or change the timberslide.conf file to explain why we need to start this early and justify any impact it may have on boot performance. Assigning to ejcaruso@ who authored the current starting stanza in https://chromium.git.corp.google.com/chromiumos/platform2/+/57333f1818c6fb36fb2fb55ff1f21eef4b6eefd9
,
Nov 16 2017
Right, there is no harm in delaying timberslide startup by a bit (it's the kernel that reads the logs from the EC, so we would not lose anything if timberslide only reads the data back from kernel a few seconds later).
,
Nov 16 2017
The only thing that might change is that if timberslide starts later the logs might not end up in feedback reports that were captured early after boot, but I'm not sure how much of a difference that will make.
,
Nov 20 2017
We'd switch to start on started system-services, which fires once the login screen has been rendered. That should be early enough for feedback reports. Agreed this probably doesn't result in observable savings in boot perf, but it's probably still a good idea to change this to match the boot flow design ideas, also for the benefit of future engineers trying to figure out how to start their service, looking at existing jobs and copying what they find ;-)
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/7c061feef98133423325ec50135480a6d693222d commit 7c061feef98133423325ec50135480a6d693222d Author: Eric Caruso <ejcaruso@chromium.org> Date: Tue Nov 28 06:50:48 2017 timberslide: move init hooks to system-services Starting on boot-services is unnecessary and might be contributing to bootperf issues, so let's start it a bit later. BUG= chromium:783114 TEST=deploy to DUT and check that it's running Change-Id: I74c78c9debd14544819539c1f660740702733173 Reviewed-on: https://chromium-review.googlesource.com/779707 Commit-Ready: Eric Caruso <ejcaruso@chromium.org> Tested-by: Eric Caruso <ejcaruso@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Mattias Nissler <mnissler@chromium.org> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> [modify] https://crrev.com/7c061feef98133423325ec50135480a6d693222d/timberslide/init/timberslide.conf
,
Nov 28 2017
,
Jan 22 2018
,
Jan 23 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ejcaruso@chromium.org
, Nov 14 2017