New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783111 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
hobby only
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 2
Type: Task



Sign in to add a comment

Fuzz CSV reader

Project Member Reported by vabr@chromium.org, Nov 9 2017

Issue description

components/password_manager/core/browser/import/password_csv_reader.* seems like a natural candidate for fuzzying and yet it does not appear to have a fuzzer defined. This bug tracks adding at least a basic one.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d923a360be7df84df6e29163991a91740c51ea1f

commit d923a360be7df84df6e29163991a91740c51ea1f
Author: Vaclav Brozek <vabr@chromium.org>
Date: Thu Nov 09 14:39:02 2017

PasswordCSVReader should reject non-ASCII URLs

URLs have a defined way to encode non-ASCII characters. The
PasswordCSVReader should reject non-ASCII URL values.

This was discovered by a fuzzer which will be uploaded in a separate
CL after this one.

Bug:  783111 
Change-Id: I5e6c640205ec45fd0764591e850363ece98a6a86
Reviewed-on: https://chromium-review.googlesource.com/758414
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515168}
[modify] https://crrev.com/d923a360be7df84df6e29163991a91740c51ea1f/components/password_manager/core/browser/import/password_csv_reader.cc
[modify] https://crrev.com/d923a360be7df84df6e29163991a91740c51ea1f/components/password_manager/core/browser/import/password_csv_reader_unittest.cc

Comment 2 by vabr@chromium.org, Nov 9 2017

Status: Assigned (was: Started)
https://chromium-review.googlesource.com/c/chromium/src/+/758773 is the fuzzer, currently in review.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dcd2a618a0b2d8ccbf9b42e24d8a298f71dc502

commit 4dcd2a618a0b2d8ccbf9b42e24d8a298f71dc502
Author: Vaclav Brozek <vabr@chromium.org>
Date: Fri Nov 10 08:51:57 2017

Add a fuzzer for CSV reader

This adds a straightforward fuzzer for
components/password_manager/core/browser/import/password_csv_reader.*
and also some seeed corpus and dictionary.

Bug:  783111 
Change-Id: Ic5193d4baa1c730db185059997c1a9fad1b2eef5
Reviewed-on: https://chromium-review.googlesource.com/758773
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515511}
[modify] https://crrev.com/4dcd2a618a0b2d8ccbf9b42e24d8a298f71dc502/components/password_manager/core/browser/BUILD.gn
[add] https://crrev.com/4dcd2a618a0b2d8ccbf9b42e24d8a298f71dc502/components/password_manager/core/browser/import/password_csv_reader_corpus/chrome_passwords.csv
[add] https://crrev.com/4dcd2a618a0b2d8ccbf9b42e24d8a298f71dc502/components/password_manager/core/browser/import/password_csv_reader_corpus/many_lines.csv
[add] https://crrev.com/4dcd2a618a0b2d8ccbf9b42e24d8a298f71dc502/components/password_manager/core/browser/import/password_csv_reader_corpus/non_ascii_url.csv
[add] https://crrev.com/4dcd2a618a0b2d8ccbf9b42e24d8a298f71dc502/components/password_manager/core/browser/import/password_csv_reader_corpus/sequences.csv
[add] https://crrev.com/4dcd2a618a0b2d8ccbf9b42e24d8a298f71dc502/components/password_manager/core/browser/import/password_csv_reader_fuzzer.cc
[add] https://crrev.com/4dcd2a618a0b2d8ccbf9b42e24d8a298f71dc502/components/password_manager/core/browser/import/password_csv_reader_fuzzer.dict

Comment 4 by vabr@chromium.org, Nov 10 2017

Status: Fixed (was: Assigned)
The fuzzer landed in r515511. It just runs the converter on the fuzzer-provided input string. If we realise we need to directly control other parameters (number of rows?) we might build up on this later.

Sign in to add a comment