New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783109 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Add AudioDeviceDescription::IsLoopbackDevice(device_id) function

Project Member Reported by marinaciocea@chromium.org, Nov 9 2017

Issue description

Add function that checks if device_id is kLoopbackInputDeviceId or kLoopbackWithMuteDeviceId, and use it in CoreAudioUtilWin.
 

Comment 1 by olka@chromium.org, Nov 9 2017

* and use it everywhere (there are several other places)
Components: Internals>Media>Audio
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6134471c6a971ab2e9707889c5bc0332397fc551

commit 6134471c6a971ab2e9707889c5bc0332397fc551
Author: Marina Ciocea <marinaciocea@chromium.org>
Date: Fri Feb 02 08:55:08 2018

Use AudioDeviceDescription::IsLoopbackDevice.

Replace duplicate implementation of AudioDeviceDescription::IsLoopbackDevice with function call.

Bug:  783109 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I896038026359723d8fe1c4366cd3a54ddd51e9c1
Reviewed-on: https://chromium-review.googlesource.com/897534
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534001}
[modify] https://crrev.com/6134471c6a971ab2e9707889c5bc0332397fc551/content/browser/renderer_host/media/audio_input_delegate_impl.cc
[modify] https://crrev.com/6134471c6a971ab2e9707889c5bc0332397fc551/media/audio/cras/cras_input.cc
[modify] https://crrev.com/6134471c6a971ab2e9707889c5bc0332397fc551/media/audio/win/audio_low_latency_input_win.cc

Status: Fixed (was: Assigned)

Sign in to add a comment