Correction: I misinterpreted the triangle at the bottom right of the cellular icon as roaming indicator. It's actually the "captive portal" indicator.  Updated the bug title.

Not sure it's a bug, so marking this issue as "feature" as we may need to discuss whether we should keep these icons consistent.

Re #1: Based on network_icon.cc, both "roaming" and "portal" state indicator may have the same issue as cr_network_icon.js doesn't seem to have the corresponding handling:

  } else if (type == shill::kTypeCellular) {
    if (network->roaming() == shill::kRoamingStateRoaming) {
      // For networks that are always in roaming don't show roaming badge.
      const DeviceState* device =
          NetworkHandler::Get()->network_state_handler()->GetDeviceState(
              network->device_path());
      LOG_IF(WARNING, !device) << "Could not find device state for "
                               << network->device_path();
      if (!device || !device->provider_requires_roaming()) {
        badges->bottom_right = {&kNetworkBadgeRoamingIcon, icon_color};    <----------
      }
    }
  }


  if (behind_captive_portal_) {
    badges->bottom_right = {&kNetworkBadgeCaptivePortalIcon, icon_color};  <----------
  }

This was an intentional change for MD to simplify the icons.

Please rope in UX if the badges are deemed important in Settings.

It would be good to review networking related icons in the System Tray and Settings UI (top-level view and expanded view).

Networking related icons have or used to have additional badges to indicate a few information: 
- connected or not
- in captive portal state
- with VPN enabled
- signal strength (WiFi, cellular, WiMAX)
- in roaming (cellular only)
- radio access technology, i.e. 3G, H+, LTE (cellular only)

Let's review each of these to decide whether they provide useful information to user. For example, not many users understand what a "captive portal" state means, but typical users would expect information like signal strength or even a roaming indicator.

The intention to simplify the icons is good and understood. It certainly applies to the settings UI where the icons can simply indicate the category of settings, rather than dynamically showing status.  The system tray is a better place to show quick status. What we need to revisit is whether to completely remove any dynamic information from the icons in the settings UI (i.e. WiFi, cellular, etc should just be a plain icon without dynamic information) and we should make that obvious, so users won't be confused by the "inconsistent" look between the icons in system tray and settings UI.

crbug.com/781776 is a related issue

Thius is not directly related to issue 781776, which is probably a missing event in the Settings UI.

For this issue we do need a UX treatment and a doc with all possible network icons for the following locations:

Settings main page (state of actice network or 'off' / 'not connected' indicator)
Settings subpage (list entry)
Settings detail page (individual network)

Status area

System tray main page
System tray subpage (list entry)

Note: Tether adds an extra level of complexity for "Mobile"

Note that for Tether networks, we currently do not have data to display for roaming state or radio access technology (e.g., LTE vs 3G).

-> sgabriel@ for UX triage

re: #1, the captive portal should be the [!] icons, the triangle is indeed the roaming. Is it possible to have a captive portal on cellular?

I've attached the current state of badging as I see it from the design side as we are going through a revamp of the status tray. Let me know if that makes sense:

Wifi has : VPN (Key icon bottom left), Captive portal ([!] bottom right), Lock (not sure what that is or if we still use it but it was in the source).
Cell has : type of network (top left), roaming (Triangle bottom right).

sgabriel@ - I don't see any attachments, did you just mean the text snippet?

Also: This issue is specifically about whether to show badges in Settings. IIRC, we explicitly decided not to, but I haven't done a recent audit as to what we should and should not show.

At one point I recall seeing a UX doc with all (most?) of the badging images. Maybe we can update / re-visit that for MD2 and re-examine what they should look like for Settings at the same time?

Oops sorry I forgot to attach it. Here you go.

I always assumed we were showing the same things in settings as we show right now the lock on the wifi with password (and that just answers by questions in #14, forgot about password :)).

If it's not the case, I think that what we display in status area should be the exact same thing we see in settings.

Deleted: cellular and wifi badges.png 97.2 KB

	cellular and wifi badges.png 97.2 KB View Download

Ah, the attachment helps. Is the "lock" badge VPN? We should include Ethernet also (I believe we show it when a VPN is active).

I'll try to do an audit of what the status tray / system menu / Settings / Config UI does.

Lock is password protected. VPN is the key on the lower left.

Oh, right, I knew that. Generally we use "secure" for "password protected".