New issue
Advanced search Search tips

Issue 783098 link

Starred by 1 user
Status: Assigned
Owner:
marja@chromium.org
Cc:
mvstanton@google.com
marja@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

45% improvement in mobile scenarios

Project Member Reported by mvstanton@google.com, Nov 9 2017 
This is to see what V8 change is responsible.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 9 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=783098

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=58cc8e62b3df8147dd7e9eda82cbc7c37515083838df9bfd9baad72dc4ad3bf2


Bot(s) for this bug's original alert(s):

android-nexus5
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Nov 9 2017 


=== BISECT JOB RESULTS ===
Perf regression found but unable to narrow commit range

Build failures prevented the bisect from narrowing the range further.


Bisect Details
  Configuration: android_nexus5_perf_bisect
  Benchmark    : v8.runtimestats.browsing_mobile
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:peak_size_max/browse_media/browse_media_youtube
  Change       : 43.08% | 7312560.0 -> 4162640.0

Suspected Commit Range
  2 commits in range
  https://chromium.googlesource.com/v8/v8.git/+log/201a40d216a416ff5ead03cd99f84f651bec3529..84294418f4e8716814a5c88d5116f9fddd250fd1


Revision                           Result              N
chromium@514502                    7312560 +- 0.0      6        good
chromium@514530                    7312560 +- 0.0      6        good
chromium@514534                    7312560 +- 0.0      6        good
chromium@514536                    7312560 +- 0.0      6        good
chromium@514536,v8@bdcab5f756      7312560 +- 0.0      6        good
chromium@514536,v8@201a40d216      7312560 +- 0.0      6        good
chromium@514536,v8@a0d1e58fdd      ---                 ---      build failure
chromium@514536,v8@84294418f4      4162640 +- 0.0      6        bad
chromium@514537                    4162640 +- 0.0      6        bad
chromium@514544                    4162640 +- 0.0      6        bad
chromium@514557                    4162640 +- 0.0      6        bad
chromium@514611                    4162640 +- 0.0      6        bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.youtube v8.runtimestats.browsing_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8963413472514363520


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Nov 9 2017

Cc: marja@chromium.org
Owner: marja@chromium.org

=== Auto-CCing suspected CL author marja@chromium.org ===

Hi marja@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Marja Hölttä
  Commit : a0d1e58fdd1e13284e0352d9f54a2c8da5e55bca
  Date   : Tue Nov 07 12:00:50 2017
  Subject: [parser] Skipping inner funcs: use ZoneChunkList instead of ZoneDeque.

Bisect Details
  Configuration: android_nexus5_perf_bisect
  Benchmark    : v8.runtimestats.browsing_mobile
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:peak_size_max/browse_media/browse_media_youtube
  Change       : 43.08% | 7312560.0 -> 4162640.0

Revision                           Result              N
chromium@514502                    7312560 +- 0.0      6      good
chromium@514530                    7312560 +- 0.0      6      good
chromium@514534                    7312560 +- 0.0      6      good
chromium@514536                    7312560 +- 0.0      6      good
chromium@514536,v8@bdcab5f756      7312560 +- 0.0      6      good
chromium@514536,v8@201a40d216      7312560 +- 0.0      6      good
chromium@514536,v8@a0d1e58fdd      4162640 +- 0.0      6      bad       <--
chromium@514536,v8@84294418f4      4162640 +- 0.0      6      bad
chromium@514537                    4162640 +- 0.0      6      bad
chromium@514544                    4162640 +- 0.0      6      bad
chromium@514557                    4162640 +- 0.0      6      bad
chromium@514611                    4162640 +- 0.0      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.youtube v8.runtimestats.browsing_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8963413412389413904


For feedback, file a bug with component Speed>Bisection

Comment 6 by mvstan...@chromium.org, Nov 9 2017 

[BTW, Heads up Marja, it's not a regression, it's just that I was wondering where the memory improvement came from.]
►

Sign in to add a comment