In 'Filter bar'/TextPrompt bar, caret gets misplaced after pressing down arrow key.
Reported by
avsha...@etouch.net,
Nov 9 2017
|
|||||||
Issue descriptionChrome version : 64.0.3263.0 (Official Build) fd1e89557fa78a467061f732a8473fd863a89b1a-refs/heads/master@{#515052} 32/64-bit OS : Windows(7,8,10), Mac(10.12.6), Linux(14.04 LTS) What steps will reproduce the problem? 1. Launch chrome and open devtools on NTP. 2. Navigate to 'Console' tab and enter 'S' in 'Filter' text field. 3. Press down arrow key from keyboard and observe the text caret in 'Filter' text field. Actual Result : Text caret gets misplaced after pressing down arrow key. Expected Result : Text caret in 'Filter' bar should not get misplaced on pressing down arrow key. This is a regression issue broken in ‘M-64’ and using the per-revision bisect providing the bisect results, Good build : 64.0.3240.0 (Revision : 508893) Bad build : 64.0.3241.0 (Revision : 508934) You are probably looking for a change made after 508916 (known good), but no later than 508917 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/0ff7688d1d4cb6da35e5989462d1d54488ddabf1..1eff80a625bd2a48a24bd2927ac67468489e8e61 Suspect : https://chromium.googlesource.com/chromium/src/+/1eff80a625bd2a48a24bd2927ac67468489e8e61 @luoe : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c03232fec035fc3164caa768b5f77e1a56bad33 commit 3c03232fec035fc3164caa768b5f77e1a56bad33 Author: Joel Einbinder <einbinder@chromium.org> Date: Fri Nov 10 23:24:12 2017 DevTools: Accept and clear autocomplete with ArrowUp/ArrowDown ArrowDown moves the cursor the right, so it needs to accept the autocomplete otherwise the cursor will be to the right of the ghost text. Bug: 783090 Change-Id: I862fb2ae37d79dcd5f507087717d16899220419a Reviewed-on: https://chromium-review.googlesource.com/762880 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Erik Luo <luoe@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#515740} [modify] https://crrev.com/3c03232fec035fc3164caa768b5f77e1a56bad33/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js
,
Nov 13 2017
Update : Retested above issue on Windows(7,8,10), Mac(10.12.6) & Linux(14.04 LTS) OS using latest Canary #64.0.3267.0 and issue is fixed. Kindly review an attached screen cast. Thank you!
,
Nov 13 2017
Note : Mac build #64.0.3267.0 is failed today, hence retested above issue using latest Mac canary #64.0.3265.0 build and the issue is no longer reproducible. The fix is working as intended. Thank you!
,
Nov 13 2017
Thanks for verifying, and thanks einbinder@ for the fix! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by l...@chromium.org
, Nov 10 2017Labels: -Pri-1 Pri-2
Owner: einbinder@chromium.org
Summary: In 'Filter bar'/TextPrompt bar, caret gets misplaced after pressing down arrow key. (was: Regression : In 'Filter' bar, text caret gets misplaced after pressing down arrow key.)