H264Decoder: accommodate H264 streams that request more reference frames than level limit |
|||
Issue descriptionSome H264 streams request more reference frames than the requested codec level limit, calculated per spec. This happens when max_num_ref_frames and/or max_dec_frame_buffering in SPS is larger than the calculated MaxDpbSize per level requested in the SPS. This is technically not allowed per spec, but we can still try to accommodate this request, as long as it remains within maximum per-spec number of reference frames, to allow playback of such streams.
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc837e94fec86df44c5288786ffa1bcb8fe67320 commit dc837e94fec86df44c5288786ffa1bcb8fe67320 Author: Pawel Osciak <posciak@chromium.org> Date: Tue Nov 14 05:26:26 2017 H264Decoder: Try to allow more reference frames than current level limit. Some non-conforming H264 streams may request a number of frames larger than the limit allowed by the codec level selected in SPS. Try to accommodate this as long as the requested number of frames is not above the per-spec upper limit of reference frames. BUG= 783074 ,b:65646253 TEST=crosvideo.appspot.com,vdaunittest,H264 conformance tests Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5443f4a567ed2934b7cf19db850bf3a03dc52926 Reviewed-on: https://chromium-review.googlesource.com/760276 Reviewed-by: Kuang-che Wu <kcwu@chromium.org> Commit-Queue: Pawel Osciak <posciak@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#515141}(cherry picked from commit 9eeda192720b6439a03021ae947ad63ce39a0c83) Reviewed-on: https://chromium-review.googlesource.com/768527 Reviewed-by: Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#478} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/dc837e94fec86df44c5288786ffa1bcb8fe67320/media/gpu/h264_decoder.cc
,
Nov 14 2017
,
Nov 16 2017
,
Dec 6 2017
,
Dec 6 2017
,
Dec 6 2017
,
Dec 6 2017
Issue 733777 has been merged into this issue.
,
Dec 18 2017
I assume this needs to be merged to M64? If so please label
,
Dec 19 2017
Merge is not required, this was submitted before M64 branched. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Nov 9 2017