New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 783058 link

Starred by 2 users
Status: Fixed
Owner:
█ warx@chromium.org
Last visit > 30 days ago
Closed: Nov 2017
Cc:
dmazz...@chromium.org
jamescook@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility

Blocked on:
issue 618070
Blocking:
issue 778438



Sign in to add a comment

TriggerAccessibilityAlert for "keyboard shortcuts for moving window between displays"

Project Member Reported by warx@chromium.org, Nov 9 2017 
We need to add new alerts in AccessibilityAlert for announcing alerts for keyboard shortcuts for moving window between displays.

However TriggerAccessibilityAlert is not mash ready. James, do you know the plan about this?

For this issue,
(1) should I still go through the existing pattern?
(2) or move TriggerAccessibilityAlert to mojo call. It doesn't look complicate to me. Maybe I can start to do the work.

Comment 1 by jamescook@chromium.org, Nov 9 2017 

Yeah, I think converting it to make it work with mash would be good. We need to replace ash AccessibilityDelegate with mojo.

I would introduce a mojo "client" interface in accessibility_manager.mojom (e.g. AccessibilityManagerClient) and put the method there, similar to how we do SessionController/SessionControllerClient. You'll need AccessibilityManager::SetClient() to set up the client from chrome/browser.

Let me know if you need help/advice.

Comment 2 by warx@chromium.org, Nov 9 2017

Blockedon: 618070
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1401124613ff9b2bb85850f5d80c7d80da72c33e

commit 1401124613ff9b2bb85850f5d80c7d80da72c33e
Author: Qiang Xu <warx@chromium.org>
Date: Tue Nov 14 19:41:50 2017

cros: send a11y alert when window moved to another display

changes:
- make moving window between displays shortcuts "window needed", which
  means a11y alert "Alert Command unavailable. Press control-N to open
  a new window" is alerted when there is no window available.
- send a11y alert when there is actual window movement by shortcuts

Bug:  783058 
Test: tested on device, working as expected; added test coverage.
Change-Id: I97a1fc2b771a10e1480a0a3dcf5107ae171e4f36
Reviewed-on: https://chromium-review.googlesource.com/767861
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516394}
[modify] https://crrev.com/1401124613ff9b2bb85850f5d80c7d80da72c33e/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/1401124613ff9b2bb85850f5d80c7d80da72c33e/ash/accelerators/accelerator_table.cc
[modify] https://crrev.com/1401124613ff9b2bb85850f5d80c7d80da72c33e/ash/display/display_move_window_util.cc
[modify] https://crrev.com/1401124613ff9b2bb85850f5d80c7d80da72c33e/ash/display/display_move_window_util_unittest.cc
[modify] https://crrev.com/1401124613ff9b2bb85850f5d80c7d80da72c33e/ash/public/interfaces/accessibility_controller.mojom
[modify] https://crrev.com/1401124613ff9b2bb85850f5d80c7d80da72c33e/chrome/app/generated_resources.grd
[modify] https://crrev.com/1401124613ff9b2bb85850f5d80c7d80da72c33e/chrome/browser/ui/ash/accessibility/accessibility_controller_client.cc

Comment 4 by warx@chromium.org, Nov 14 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment