Implement a clear UI on Clank for user language preferences to allow users to seamlessly find and manage their preferences across platforms. PRD: go/chrome-language-controls Mocks: go/clank-language-settings
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffdb85f056d19d569ef62a88e054d288e31b57ec commit ffdb85f056d19d569ef62a88e054d288e31b57ec Author: Leo Zhang <googleo@chromium.org> Date: Fri Nov 10 01:43:58 2017 Add an empty languages settings page on Clank. Add a new languages prefs page under "Settings" and create an experiment to protect the feature until it's launched. Tested locally, screenshots: https://screenshot.googleplex.com/FroXGdSY26V https://screenshot.googleplex.com/m3ym9gvsysg Bug: 783049 Change-Id: I6e99d8833392e0df9e7c35ce0f52bd46fd31e69a Reviewed-on: https://chromium-review.googlesource.com/760081 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#515410} [modify] https://crrev.com/ffdb85f056d19d569ef62a88e054d288e31b57ec/chrome/android/java/res/xml/main_preferences.xml [modify] https://crrev.com/ffdb85f056d19d569ef62a88e054d288e31b57ec/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/ffdb85f056d19d569ef62a88e054d288e31b57ec/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java [add] https://crrev.com/ffdb85f056d19d569ef62a88e054d288e31b57ec/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguagesPreferences.java [modify] https://crrev.com/ffdb85f056d19d569ef62a88e054d288e31b57ec/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/ffdb85f056d19d569ef62a88e054d288e31b57ec/chrome/android/java_sources.gni [modify] https://crrev.com/ffdb85f056d19d569ef62a88e054d288e31b57ec/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/ffdb85f056d19d569ef62a88e054d288e31b57ec/chrome/browser/android/chrome_feature_list.h
I think this feature is going to require quite a bit of code, including some custom UI code and code somewhere to make sure languages match those available on desktop. I think this warrants a design doc. googleo@, what do you think?
Hey Theresa, I had created a Design Doc a few weeks ago. https://docs.google.com/a/google.com/document/d/1uisJgE3PVzxp-5uV6-aOU9dEQhquq8bEZAmJFRbWF2U/edit?usp=sharing Due to its complexity (business logic and layout/native design), It's still in progress. I keep the doc updated. I will send it out soon.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb178abd808e39b65a0d86c2b999546b16d9c556 commit fb178abd808e39b65a0d86c2b999546b16d9c556 Author: Leo Zhang <googleo@chromium.org> Date: Thu Nov 30 22:19:07 2017 Add language list and disable button in languages prefs. Add turn on/off translate switch. Read accept_langauges from native and show them in the languages page. For each language item, add a fake option memu. Screenshot: https://screenshot.googleplex.com/0HOVztouukP Bug: 783049 Change-Id: If420d76fe12ecbff277bcd6e4ab7a3a7a3419f63 Reviewed-on: https://chromium-review.googlesource.com/762540 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#520715} [add] https://crrev.com/fb178abd808e39b65a0d86c2b999546b16d9c556/chrome/android/java/res/drawable-hdpi/ic_drag_handle_grey600_24dp.png [add] https://crrev.com/fb178abd808e39b65a0d86c2b999546b16d9c556/chrome/android/java/res/drawable-mdpi/ic_drag_handle_grey600_24dp.png [add] https://crrev.com/fb178abd808e39b65a0d86c2b999546b16d9c556/chrome/android/java/res/drawable-xhdpi/ic_drag_handle_grey600_24dp.png [add] https://crrev.com/fb178abd808e39b65a0d86c2b999546b16d9c556/chrome/android/java/res/drawable-xxhdpi/ic_drag_handle_grey600_24dp.png [add] https://crrev.com/fb178abd808e39b65a0d86c2b999546b16d9c556/chrome/android/java/res/drawable-xxxhdpi/ic_drag_handle_grey600_24dp.png [add] https://crrev.com/fb178abd808e39b65a0d86c2b999546b16d9c556/chrome/android/java/res/layout/accept_languages_item.xml [add] https://crrev.com/fb178abd808e39b65a0d86c2b999546b16d9c556/chrome/android/java/res/layout/accept_languages_list.xml [modify] https://crrev.com/fb178abd808e39b65a0d86c2b999546b16d9c556/chrome/android/java/res/layout/list_menu_item.xml [modify] https://crrev.com/fb178abd808e39b65a0d86c2b999546b16d9c556/chrome/android/java/res/values/attrs.xml [modify] https://crrev.com/fb178abd808e39b65a0d86c2b999546b16d9c556/chrome/android/java/res/values/dimens.xml [add] https://crrev.com/fb178abd808e39b65a0d86c2b999546b16d9c556/chrome/android/java/res/xml/languages_preferences.xml [modify] https://crrev.com/fb178abd808e39b65a0d86c2b999546b16d9c556/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java [add] https://crrev.com/fb178abd808e39b65a0d86c2b999546b16d9c556/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguageListPreference.java [add] https://crrev.com/fb178abd808e39b65a0d86c2b999546b16d9c556/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguageSelectionPreferences.java [modify] https://crrev.com/fb178abd808e39b65a0d86c2b999546b16d9c556/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguagesPreferences.java [modify] https://crrev.com/fb178abd808e39b65a0d86c2b999546b16d9c556/chrome/android/java/src/org/chromium/chrome/browser/widget/ListMenuButton.java [modify] https://crrev.com/fb178abd808e39b65a0d86c2b999546b16d9c556/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/fb178abd808e39b65a0d86c2b999546b16d9c556/chrome/android/java_sources.gni [modify] https://crrev.com/fb178abd808e39b65a0d86c2b999546b16d9c556/chrome/browser/android/preferences/pref_service_bridge.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63f56a146fbd26801b7d91fb2b7fe42c8ca42cc1 commit 63f56a146fbd26801b7d91fb2b7fe42c8ca42cc1 Author: Leo Zhang <googleo@chromium.org> Date: Mon Dec 04 05:47:18 2017 Implementation for Languages settings (Part 2). This CL is based on crrev.com/c/762540 1, Polish the UI. 2, Reading all language infos from native. 3, Enable "Remove" in the language menu. 4, Enable "Add language" for the settings page. 5, Created "Add language" fragment, it will list all unselected languages and provide a "search" function for users to find the language quickly. Tested on my local devices, demo video link https: //googleo.users.x20web.corp.google.com/screenrecord/chrome/lang-settings.mp4 Bug: 783049 Change-Id: Ie5fdba908a99ad1116538bd69fe9c703c4c9051a Reviewed-on: https://chromium-review.googlesource.com/790091 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#521276} [modify] https://crrev.com/63f56a146fbd26801b7d91fb2b7fe42c8ca42cc1/chrome/android/java/res/layout/accept_languages_item.xml [modify] https://crrev.com/63f56a146fbd26801b7d91fb2b7fe42c8ca42cc1/chrome/android/java/res/layout/accept_languages_list.xml [add] https://crrev.com/63f56a146fbd26801b7d91fb2b7fe42c8ca42cc1/chrome/android/java/res/layout/add_languages_main.xml [add] https://crrev.com/63f56a146fbd26801b7d91fb2b7fe42c8ca42cc1/chrome/android/java/res/layout/languages_preference.xml [add] https://crrev.com/63f56a146fbd26801b7d91fb2b7fe42c8ca42cc1/chrome/android/java/res/menu/languages_action_bar_menu.xml [modify] https://crrev.com/63f56a146fbd26801b7d91fb2b7fe42c8ca42cc1/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/63f56a146fbd26801b7d91fb2b7fe42c8ca42cc1/chrome/android/java/res/xml/languages_preferences.xml [modify] https://crrev.com/63f56a146fbd26801b7d91fb2b7fe42c8ca42cc1/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java [add] https://crrev.com/63f56a146fbd26801b7d91fb2b7fe42c8ca42cc1/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/AddLanguageFragment.java [add] https://crrev.com/63f56a146fbd26801b7d91fb2b7fe42c8ca42cc1/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguageItem.java [add] https://crrev.com/63f56a146fbd26801b7d91fb2b7fe42c8ca42cc1/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguageListBaseAdapter.java [modify] https://crrev.com/63f56a146fbd26801b7d91fb2b7fe42c8ca42cc1/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguageListPreference.java [add] https://crrev.com/63f56a146fbd26801b7d91fb2b7fe42c8ca42cc1/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguagesManager.java [modify] https://crrev.com/63f56a146fbd26801b7d91fb2b7fe42c8ca42cc1/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguagesPreferences.java [modify] https://crrev.com/63f56a146fbd26801b7d91fb2b7fe42c8ca42cc1/chrome/android/java_sources.gni [modify] https://crrev.com/63f56a146fbd26801b7d91fb2b7fe42c8ca42cc1/chrome/browser/android/preferences/pref_service_bridge.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b82f754c717dbf442ab1ddbb0e9f0bca520f7a9 commit 3b82f754c717dbf442ab1ddbb0e9f0bca520f7a9 Author: Leo Zhang <googleo@chromium.org> Date: Wed Dec 20 01:54:40 2017 Support drag and drop for the language accept list. Add a ItemTouchHelper in the LanguageListBaseAdapter to support Drag&drop, and clean up some code. Tested on locale devices and emulator. Demo video link on Pixel, it shows how the "long-click" and "drag handler" works. https://googleo.users.x20web.corp.google.com/screenrecord/chrome/lang-settings-drag.mp4 Bug: 783049 Change-Id: Ibac2fd045036a3ae6974c9ffe08cc6231b57e65f Reviewed-on: https://chromium-review.googlesource.com/826884 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#525222} [modify] https://crrev.com/3b82f754c717dbf442ab1ddbb0e9f0bca520f7a9/chrome/android/java/res/values/colors.xml [modify] https://crrev.com/3b82f754c717dbf442ab1ddbb0e9f0bca520f7a9/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/3b82f754c717dbf442ab1ddbb0e9f0bca520f7a9/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java [modify] https://crrev.com/3b82f754c717dbf442ab1ddbb0e9f0bca520f7a9/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/AddLanguageFragment.java [modify] https://crrev.com/3b82f754c717dbf442ab1ddbb0e9f0bca520f7a9/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguageListBaseAdapter.java [modify] https://crrev.com/3b82f754c717dbf442ab1ddbb0e9f0bca520f7a9/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguageListPreference.java [modify] https://crrev.com/3b82f754c717dbf442ab1ddbb0e9f0bca520f7a9/chrome/browser/android/preferences/pref_service_bridge.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/051b75484c39f55b6e7fc49ea7afea844c614d72 commit 051b75484c39f55b6e7fc49ea7afea844c614d72 Author: Leo Zhang <googleo@chromium.org> Date: Wed Dec 20 03:28:30 2017 Add language preference flag to chrome://flags page on Android. Bug: 783049 Change-Id: I162ac00846be5e267d206a89e8e2d652ec603874 Reviewed-on: https://chromium-review.googlesource.com/831379 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#525247} [modify] https://crrev.com/051b75484c39f55b6e7fc49ea7afea844c614d72/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferences.java [modify] https://crrev.com/051b75484c39f55b6e7fc49ea7afea844c614d72/chrome/browser/about_flags.cc [modify] https://crrev.com/051b75484c39f55b6e7fc49ea7afea844c614d72/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/051b75484c39f55b6e7fc49ea7afea844c614d72/chrome/browser/flag_descriptions.h [modify] https://crrev.com/051b75484c39f55b6e7fc49ea7afea844c614d72/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e475c8f306fab051ba9e7bcba48479691ee6b9b3 commit e475c8f306fab051ba9e7bcba48479691ee6b9b3 Author: Leo Zhang <googleo@chromium.org> Date: Thu Jan 04 01:04:04 2018 Enable "Offer to translate" for each language item. Add native read/write functions for language's blocked state. Once the user selects the enabled menu item, it will toggle the state. Demo link: https://googleo.users.x20web.corp.google.com/screenrecord/lang-settings-toggle.mp4 Bug: 783049 Change-Id: I3b144d1b0c23705931b480dc9a869a0efe0dae00 Reviewed-on: https://chromium-review.googlesource.com/848753 Reviewed-by: Ted Choc (back but slow, ping me) <tedchoc@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#526879} [modify] https://crrev.com/e475c8f306fab051ba9e7bcba48479691ee6b9b3/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java [modify] https://crrev.com/e475c8f306fab051ba9e7bcba48479691ee6b9b3/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguageListPreference.java [modify] https://crrev.com/e475c8f306fab051ba9e7bcba48479691ee6b9b3/chrome/browser/android/preferences/pref_service_bridge.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f3c62bf6dfa798457f7144360512847a9beb24e commit 2f3c62bf6dfa798457f7144360512847a9beb24e Author: Leo Zhang <googleo@chromium.org> Date: Fri Jan 05 04:32:35 2018 Add loggings for languages settings. Add page impression and actions logging to monitor the new feature. Tested on my devices, all metrics were logged in the chrome://histograms Bug: 783049 Change-Id: I3d4ac98ed9550763987a2c1f912037715e8e61b8 Reviewed-on: https://chromium-review.googlesource.com/850493 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by: Ted Choc (back but slow, ping me) <tedchoc@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#527209} [modify] https://crrev.com/2f3c62bf6dfa798457f7144360512847a9beb24e/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/AddLanguageFragment.java [modify] https://crrev.com/2f3c62bf6dfa798457f7144360512847a9beb24e/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguageListBaseAdapter.java [modify] https://crrev.com/2f3c62bf6dfa798457f7144360512847a9beb24e/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguageListPreference.java [modify] https://crrev.com/2f3c62bf6dfa798457f7144360512847a9beb24e/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguagesManager.java [modify] https://crrev.com/2f3c62bf6dfa798457f7144360512847a9beb24e/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguagesPreferences.java [modify] https://crrev.com/2f3c62bf6dfa798457f7144360512847a9beb24e/tools/metrics/histograms/enums.xml [modify] https://crrev.com/2f3c62bf6dfa798457f7144360512847a9beb24e/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39e67b25b7b45d01f3e74a9e1520576790cff93d commit 39e67b25b7b45d01f3e74a9e1520576790cff93d Author: Claudio Magni <claudiomagni@chromium.org> Date: Mon Jan 08 06:15:06 2018 Changed Language Settings API to support Drag&Drop. With Language Settings being implemented in Android too, we need to support in native moving a language up/down the list by more than one position. Bug: 783049 Change-Id: Ic5f2a2e1c9dc1673252d19268fcc7ffbeaf7f342 Reviewed-on: https://chromium-review.googlesource.com/845239 Commit-Queue: Claudio M <claudiomagni@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Leo Zhang <googleo@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Ted Choc (back but slow, ping me) <tedchoc@chromium.org> Reviewed-by: Renjie Liu <renjieliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#527580} [modify] https://crrev.com/39e67b25b7b45d01f3e74a9e1520576790cff93d/chrome/browser/android/preferences/pref_service_bridge.cc [modify] https://crrev.com/39e67b25b7b45d01f3e74a9e1520576790cff93d/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc [modify] https://crrev.com/39e67b25b7b45d01f3e74a9e1520576790cff93d/components/translate/core/browser/translate_prefs.cc [modify] https://crrev.com/39e67b25b7b45d01f3e74a9e1520576790cff93d/components/translate/core/browser/translate_prefs.h [modify] https://crrev.com/39e67b25b7b45d01f3e74a9e1520576790cff93d/components/translate/core/browser/translate_prefs_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0986bd62e56a9e2ef35e1757c1fdba8e0da609b commit d0986bd62e56a9e2ef35e1757c1fdba8e0da609b Author: Leo Zhang <googleo@chromium.org> Date: Wed Jan 10 23:29:27 2018 Fix some bugs of language settings. * Fix the empty menu item crash when there is only one item without translation enabled. * Disable the drag&drop when there is only one row. * Commit the language postion change only when the item is dropped In this way, it's efficient when there are multiple movements during a single drag operation. Bug: 800260, 783049 Change-Id: Ic56efbc2531047eff3e56128250426c8aa9e3a20 Reviewed-on: https://chromium-review.googlesource.com/858618 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#528475} [modify] https://crrev.com/d0986bd62e56a9e2ef35e1757c1fdba8e0da609b/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguageListBaseAdapter.java [modify] https://crrev.com/d0986bd62e56a9e2ef35e1757c1fdba8e0da609b/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguageListPreference.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05451c1b69debbc979f92dcd62ae20d016a6d539 commit 05451c1b69debbc979f92dcd62ae20d016a6d539 Author: Leo Zhang <googleo@chromium.org> Date: Mon Jan 15 03:17:38 2018 Fix bugs and code cleanup for language settings in Clank. * Fix accessibility message with "unlabeled". * Fix "Offer to translate" option for System UI language. * Get rid of unused class. Demo link: https://googleo.users.x20web.corp.google.com/screenrecord/chrome/lang-settings-access-demo.mp4 Bug: 782375, 783049 Change-Id: Ibc1bea760e4f158e32e5e0ebb24ba536c10add72 Reviewed-on: https://chromium-review.googlesource.com/861561 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#529192} [modify] https://crrev.com/05451c1b69debbc979f92dcd62ae20d016a6d539/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguageListBaseAdapter.java [modify] https://crrev.com/05451c1b69debbc979f92dcd62ae20d016a6d539/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguageListPreference.java [delete] https://crrev.com/358e6391fd02aaa94584159fbb1720040a5467dc/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguageSelectionPreferences.java [modify] https://crrev.com/05451c1b69debbc979f92dcd62ae20d016a6d539/chrome/browser/android/preferences/pref_service_bridge.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26d5480ae37d0926b9eba4daef48efe3013fa6d4 commit 26d5480ae37d0926b9eba4daef48efe3013fa6d4 Author: Leo Zhang <googleo@chromium.org> Date: Tue Jan 16 23:06:17 2018 Fix the style of 'add language' button. Based on the feedbacks from PM and UX, updating "Add language" button's style as "Add Card" and "Add address" in payment preference. Screenshot: https://screenshot.googleplex.com/vdwHitewngs Bug: 783049 Change-Id: Ie22c2180e273b95fc88c1304dd6d184caa6743a1 Reviewed-on: https://chromium-review.googlesource.com/866520 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#529515} [modify] https://crrev.com/26d5480ae37d0926b9eba4daef48efe3013fa6d4/chrome/android/java/res/layout/languages_preference.xml [modify] https://crrev.com/26d5480ae37d0926b9eba4daef48efe3013fa6d4/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguageListPreference.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df331b4b8b098e3d727fba84f28f96a8f6a68da1 commit df331b4b8b098e3d727fba84f28f96a8f6a68da1 Author: Leo Zhang <googleo@chromium.org> Date: Wed Jan 17 22:52:10 2018 Fix text style for language settings list. Reuse the layout of modern_list_item_view for language list item and customize Texts style. Screenshot: https://screenshot.googleplex.com/MKDv8PxNtEW Bug: 783049 Change-Id: I354ce7b2e16434e28bc963142ea9d6827d66247e Reviewed-on: https://chromium-review.googlesource.com/869210 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#529936} [modify] https://crrev.com/df331b4b8b098e3d727fba84f28f96a8f6a68da1/chrome/android/java/res/layout/accept_languages_item.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c08cdfe3a67d6efd10117350451f95992458825 commit 1c08cdfe3a67d6efd10117350451f95992458825 Author: Leo Zhang <googleo@chromium.org> Date: Thu Jan 18 05:36:35 2018 Fix "options" button padding on main language setting page. Based on the feedback from our UX, set the language row end padding to 0 dynamically. Screenshot: main page: https://screenshot.googleplex.com/A8u7SexS3ZX add language page: https://screenshot.googleplex.com/JszTnGsVtcc Bug: 783049 Change-Id: I27381e254dfffb80ad0fcdba87c53ce9b139f199 Reviewed-on: https://chromium-review.googlesource.com/872130 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#530063} [modify] https://crrev.com/1c08cdfe3a67d6efd10117350451f95992458825/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguageListBaseAdapter.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f6f2a6ec6099816ad4f1227e552c78e2bfca640 commit 5f6f2a6ec6099816ad4f1227e552c78e2bfca640 Author: Leo Zhang <googleo@chromium.org> Date: Tue Jan 30 00:29:14 2018 Set application language always blocked. In some corner case, the application language isn't blocked due to its legacy state, so we set app language blocked always. Bug: 783049 Change-Id: I13924b12bf2353217db902bc48796ea74cfafd7f Reviewed-on: https://chromium-review.googlesource.com/890147 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#532693} [modify] https://crrev.com/5f6f2a6ec6099816ad4f1227e552c78e2bfca640/chrome/browser/android/preferences/pref_service_bridge.cc
Leo - is it ok to mark this issue as fixed or are you still working on some small changes?
Yes, I think it's fixed Not working on bugs now.
Comment 1 by bugdroid1@chromium.org
, Nov 10 2017