New issue
Advanced search Search tips

Issue 783035 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

CHECK failure: Representation inference: unsupported opcode 61 (Dead), node #NUMBER in simplifi

Project Member Reported by ClusterFuzz, Nov 9 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6470259933708288

Fuzzer: ochang_js_fuzzer
Job Type: linux_ubsan_vptr_d8
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  Representation inference: unsupported opcode 61 (Dead), node #NUMBER in simplifi
  v8::internal::compiler::RepresentationSelector::VisitNode
  v8::internal::compiler::RepresentationSelector::RunTruncationPropagationPhase
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_d8&range=49187:49188

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6470259933708288

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 9 2017

Components: Blink>JavaScript>Compiler
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Nov 9 2017

Labels: Test-Predator-Auto-Owner
Owner: tebbi@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/ac0661b358bce7f9af6f23c3e640121f6ca20170 (Reland^5 "[turbofan] eagerly prune None types and deadness from the graph").

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c899637debff1e05ac40a1e0d50b0da588df645b

commit c899637debff1e05ac40a1e0d50b0da588df645b
Author: Tobias Tebbi <tebbi@chromium.org>
Date: Thu Nov 09 11:00:45 2017

Revert "Reland^5 "[turbofan] eagerly prune None types and deadness from the graph""

This reverts commit ac0661b358bce7f9af6f23c3e640121f6ca20170.

Reason for revert: Clusterfuzz unhappy: chromium:783019 chromium:783035

Original change's description:
> Reland^5 "[turbofan] eagerly prune None types and deadness from the graph"
>
> This gives up on earlier attempts to interpret DeadValue as a signal of
> unreachable code. This does not work because free-floating dead value
> nodes, and even pure branch nodes that use them, can get scheduled so
> early that they get reachable. Instead, we now eagerly remove branches
> that use DeadValue in DeadCodeElimination and replace DeadValue inputs
> to value phi nodes with dummy values.
>
> Reland of https://chromium-review.googlesource.com/715716
>
> Bug: chromium:741225  chromium:776256 
> Change-Id: I251efd507c967d4a8882ad8fd2fd96c4185781fe
> Reviewed-on: https://chromium-review.googlesource.com/727893
> Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#49188}

TBR=jarin@chromium.org,tebbi@chromium.org

Bug: chromium:741225  chromium:776256   chromium:783019   chromium:783035 
Change-Id: I6a8fa3a08ce2824a858ae01817688e63ed1f442e
Reviewed-on: https://chromium-review.googlesource.com/758770
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49262}
[modify] https://crrev.com/c899637debff1e05ac40a1e0d50b0da588df645b/src/compiler/branch-elimination.cc
[modify] https://crrev.com/c899637debff1e05ac40a1e0d50b0da588df645b/src/compiler/common-operator.cc
[modify] https://crrev.com/c899637debff1e05ac40a1e0d50b0da588df645b/src/compiler/common-operator.h
[modify] https://crrev.com/c899637debff1e05ac40a1e0d50b0da588df645b/src/compiler/dead-code-elimination.cc
[modify] https://crrev.com/c899637debff1e05ac40a1e0d50b0da588df645b/src/compiler/dead-code-elimination.h
[modify] https://crrev.com/c899637debff1e05ac40a1e0d50b0da588df645b/src/compiler/effect-control-linearizer.cc
[modify] https://crrev.com/c899637debff1e05ac40a1e0d50b0da588df645b/src/compiler/instruction-selector.cc
[modify] https://crrev.com/c899637debff1e05ac40a1e0d50b0da588df645b/src/compiler/instruction-selector.h
[modify] https://crrev.com/c899637debff1e05ac40a1e0d50b0da588df645b/src/compiler/js-graph.cc
[modify] https://crrev.com/c899637debff1e05ac40a1e0d50b0da588df645b/src/compiler/js-graph.h
[modify] https://crrev.com/c899637debff1e05ac40a1e0d50b0da588df645b/src/compiler/memory-optimizer.cc
[modify] https://crrev.com/c899637debff1e05ac40a1e0d50b0da588df645b/src/compiler/opcodes.h
[modify] https://crrev.com/c899637debff1e05ac40a1e0d50b0da588df645b/src/compiler/pipeline.cc
[modify] https://crrev.com/c899637debff1e05ac40a1e0d50b0da588df645b/src/compiler/representation-change.cc
[modify] https://crrev.com/c899637debff1e05ac40a1e0d50b0da588df645b/src/compiler/simplified-lowering.cc
[modify] https://crrev.com/c899637debff1e05ac40a1e0d50b0da588df645b/src/compiler/typer.cc
[modify] https://crrev.com/c899637debff1e05ac40a1e0d50b0da588df645b/src/compiler/verifier.cc
[delete] https://crrev.com/d1193e3c6ce24394b60717fd21aa042e4d94ce00/test/mjsunit/compiler/regress-772872.js
[delete] https://crrev.com/d1193e3c6ce24394b60717fd21aa042e4d94ce00/test/mjsunit/compiler/regress-773954.js
[modify] https://crrev.com/c899637debff1e05ac40a1e0d50b0da588df645b/test/unittests/compiler/dead-code-elimination-unittest.cc

Project Member

Comment 4 by sheriffbot@chromium.org, Nov 9 2017

Labels: Pri-1
Labels: Security_Impact-Head M-64
Project Member

Comment 6 by ClusterFuzz, Nov 10 2017

ClusterFuzz has detected this issue as fixed in range 49261:49262.

Detailed report: https://clusterfuzz.com/testcase?key=6470259933708288

Fuzzer: ochang_js_fuzzer
Job Type: linux_ubsan_vptr_d8
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  Representation inference: unsupported opcode 61 (Dead), node #NUMBER in simplifi
  v8::internal::compiler::RepresentationSelector::VisitNode
  v8::internal::compiler::RepresentationSelector::RunTruncationPropagationPhase
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_d8&range=49187:49188
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_d8&range=49261:49262

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6470259933708288

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Nov 10 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6470259933708288 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 8 by sheriffbot@chromium.org, Nov 10 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/19ac10e58af7768b2e4eb57f460169f11f97fcf1

commit 19ac10e58af7768b2e4eb57f460169f11f97fcf1
Author: Tobias Tebbi <tebbi@chromium.org>
Date: Thu Nov 16 20:01:22 2017

Reland^6 "[turbofan] eagerly prune None types and deadness from the graph"

Reland of https://chromium-review.googlesource.com/c/v8/v8/+/727893
The crashes should be fixed by https://chromium-review.googlesource.com/c/v8/v8/+/763531

Original change's description:
> Revert "Reland^5 "[turbofan] eagerly prune None types and deadness from the graph""
> 
> This reverts commit ac0661b358bce7f9af6f23c3e640121f6ca20170.
> 
> Reason for revert: Clusterfuzz unhappy: chromium:783019 chromium:783035
> 
> Original change's description:
> > Reland^5 "[turbofan] eagerly prune None types and deadness from the graph"
> >
> > This gives up on earlier attempts to interpret DeadValue as a signal of
> > unreachable code. This does not work because free-floating dead value
> > nodes, and even pure branch nodes that use them, can get scheduled so
> > early that they get reachable. Instead, we now eagerly remove branches
> > that use DeadValue in DeadCodeElimination and replace DeadValue inputs
> > to value phi nodes with dummy values.
> >
> > Reland of https://chromium-review.googlesource.com/715716
> >
> > Bug: chromium:741225  chromium:776256 
> > Change-Id: I251efd507c967d4a8882ad8fd2fd96c4185781fe
> > Reviewed-on: https://chromium-review.googlesource.com/727893
> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#49188}
> 
> TBR=jarin@chromium.org,tebbi@chromium.org
> 
> Bug: chromium:741225  chromium:776256   chromium:783019   chromium:783035 
> Change-Id: I6a8fa3a08ce2824a858ae01817688e63ed1f442e
> Reviewed-on: https://chromium-review.googlesource.com/758770
> Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
> Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#49262}

TBR=jarin@chromium.org,tebbi@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:741225  chromium:776256   chromium:783019   chromium:783035 
Change-Id: I6c02b4beb02997ec34015ed2f6791a93c70f5e36
Reviewed-on: https://chromium-review.googlesource.com/772150
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49429}
[modify] https://crrev.com/19ac10e58af7768b2e4eb57f460169f11f97fcf1/src/compiler/branch-elimination.cc
[modify] https://crrev.com/19ac10e58af7768b2e4eb57f460169f11f97fcf1/src/compiler/common-operator.cc
[modify] https://crrev.com/19ac10e58af7768b2e4eb57f460169f11f97fcf1/src/compiler/common-operator.h
[modify] https://crrev.com/19ac10e58af7768b2e4eb57f460169f11f97fcf1/src/compiler/dead-code-elimination.cc
[modify] https://crrev.com/19ac10e58af7768b2e4eb57f460169f11f97fcf1/src/compiler/dead-code-elimination.h
[modify] https://crrev.com/19ac10e58af7768b2e4eb57f460169f11f97fcf1/src/compiler/effect-control-linearizer.cc
[modify] https://crrev.com/19ac10e58af7768b2e4eb57f460169f11f97fcf1/src/compiler/instruction-selector.cc
[modify] https://crrev.com/19ac10e58af7768b2e4eb57f460169f11f97fcf1/src/compiler/instruction-selector.h
[modify] https://crrev.com/19ac10e58af7768b2e4eb57f460169f11f97fcf1/src/compiler/js-graph.cc
[modify] https://crrev.com/19ac10e58af7768b2e4eb57f460169f11f97fcf1/src/compiler/js-graph.h
[modify] https://crrev.com/19ac10e58af7768b2e4eb57f460169f11f97fcf1/src/compiler/memory-optimizer.cc
[modify] https://crrev.com/19ac10e58af7768b2e4eb57f460169f11f97fcf1/src/compiler/opcodes.h
[modify] https://crrev.com/19ac10e58af7768b2e4eb57f460169f11f97fcf1/src/compiler/pipeline.cc
[modify] https://crrev.com/19ac10e58af7768b2e4eb57f460169f11f97fcf1/src/compiler/representation-change.cc
[modify] https://crrev.com/19ac10e58af7768b2e4eb57f460169f11f97fcf1/src/compiler/simplified-lowering.cc
[modify] https://crrev.com/19ac10e58af7768b2e4eb57f460169f11f97fcf1/src/compiler/typer.cc
[modify] https://crrev.com/19ac10e58af7768b2e4eb57f460169f11f97fcf1/src/compiler/verifier.cc
[add] https://crrev.com/19ac10e58af7768b2e4eb57f460169f11f97fcf1/test/mjsunit/compiler/regress-772872.js
[add] https://crrev.com/19ac10e58af7768b2e4eb57f460169f11f97fcf1/test/mjsunit/compiler/regress-773954.js
[modify] https://crrev.com/19ac10e58af7768b2e4eb57f460169f11f97fcf1/test/unittests/compiler/dead-code-elimination-unittest.cc

Project Member

Comment 10 by sheriffbot@chromium.org, Feb 16 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head -M-64 M-65 Security_Impact-Stable

Sign in to add a comment