New issue
Advanced search Search tips

Issue 783033 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

[iOS] Redesign JavaScriptDialogPresenter to be testable.

Project Member Reported by kkhorimoto@chromium.org, Nov 9 2017

Issue description

The current interface to JavaScriptDialogPresenter is not easily testable.  JavaScriptDialogPresenterImpl, the legacy implementation, is only tested implicitly through EG tests that show JavaScript dialogs.  After BrowserCoordinators are incorporated into ios/chrome, this will be replaced by JavaScriptDialogOverlayPresenter.  This can be tested by updated the constructor of that class to take an OverlayService (rather than grabbing it from its Browser), then create a TestOverlayService that can be used to verify the state of the produced DialogCoordinators.
 
Components: Mobile>WebView>Glue
Components: -Mobile>WebView>Glue UI>Browser>Core
Labels: -Type-Bug Type-Task
We usually use UI>Browser>Core,  for the dialogs

Sign in to add a comment