New issue
Advanced search Search tips

Issue 783031 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 545318



Sign in to add a comment

[css-typed-om] CSSURLImageValue doesn't support relative URLs

Project Member Reported by shend@chromium.org, Nov 9 2017

Issue description

The CSSURLImageValue constructor should support relative URLs. It currently only supports absolute URLs. This probably involves using the correct parser context when parsing the URL.

Spec: https://drafts.css-houdini.org/css-typed-om-1/#imagevalue-objects
 

Comment 1 by shend@chromium.org, Nov 9 2017

Blocking: 545318

Comment 2 by shend@chromium.org, Nov 9 2017

Owner: shend@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b3ffb0392312bc3d08fab7db53c160e28e8c6fa

commit 8b3ffb0392312bc3d08fab7db53c160e28e8c6fa
Author: Darren Shen <shend@chromium.org>
Date: Fri Nov 10 07:01:04 2017

[css-typed-om] Support relative URLs in CSSURLImageValue.

We currently don't support relative URLs. This patch uses ScriptState
to resolve relative URLs. Note that the CSSURLImageValue.url needs to
return the original (relative) url given by the constructor. Since
CSSImageValue already stores the relative url for serialization, we
only need to expose it to CSSURLImageValue.

Bug:  783031 
Change-Id: I12b7ae8e98306e4debd6d3b1a9fd1ef1eca9752e
Reviewed-on: https://chromium-review.googlesource.com/760057
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515491}
[modify] https://crrev.com/8b3ffb0392312bc3d08fab7db53c160e28e8c6fa/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssUrlImageValue.html
[modify] https://crrev.com/8b3ffb0392312bc3d08fab7db53c160e28e8c6fa/third_party/WebKit/Source/core/css/CSSImageValue.h
[modify] https://crrev.com/8b3ffb0392312bc3d08fab7db53c160e28e8c6fa/third_party/WebKit/Source/core/css/cssom/CSSURLImageValue.h
[modify] https://crrev.com/8b3ffb0392312bc3d08fab7db53c160e28e8c6fa/third_party/WebKit/Source/core/css/cssom/CSSURLImageValue.idl

Comment 4 by shend@chromium.org, Nov 12 2017

Cc: shend@chromium.org
Owner: ----
Status: Available (was: Started)
There's one more spot where we need to resolve relative URLs: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.cpp?q=CSSStyleValue&sq=package:chromium&l=35

Should be similar to the previous commit. Unassigning myself as I'm not currently working on this.
Owner: hs1217....@samsung.com
Status: Started (was: Available)
i will take this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/586404c89f9f718cda609316d67bf1745afc1a88

commit 586404c89f9f718cda609316d67bf1745afc1a88
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Mon Nov 27 01:52:36 2017

[css-typed-om] Parseing relative URLs from strings

when style value parsing from strings,
StrictCSSParserContext was used. so relative URLs was not parsed.
StrictCSSParserContext replaced with ExecutionContext
in order to parse relatvie URLs.

Bug:  783031 
Change-Id: I4d375dd1a5452d08883d6726e95e1b7baebb3816
Reviewed-on: https://chromium-review.googlesource.com/781640
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#519204}
[add] https://crrev.com/586404c89f9f718cda609316d67bf1745afc1a88/third_party/WebKit/LayoutTests/typedcssom/stylevalue-objects/parse-relative-url.html
[modify] https://crrev.com/586404c89f9f718cda609316d67bf1745afc1a88/third_party/WebKit/Source/core/css/CSSImageValue.h
[modify] https://crrev.com/586404c89f9f718cda609316d67bf1745afc1a88/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.cpp
[modify] https://crrev.com/586404c89f9f718cda609316d67bf1745afc1a88/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp
[modify] https://crrev.com/586404c89f9f718cda609316d67bf1745afc1a88/third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp
[modify] https://crrev.com/586404c89f9f718cda609316d67bf1745afc1a88/third_party/WebKit/Source/core/css/cssom/StyleValueFactory.h
[modify] https://crrev.com/586404c89f9f718cda609316d67bf1745afc1a88/third_party/WebKit/Source/core/css/parser/CSSParserContext.h

Comment 7 by shend@chromium.org, Nov 27 2017

Labels: -Hotlist-Interop
Labels: -Update-Monthly
Status: Fixed (was: Started)

Sign in to add a comment