Window titlebars are not dark when using the dark GTK theme |
|||
Issue descriptionSee attached the video. Chrome windows don't have dark titlebars, but other apps do (even ones that don't use CSD).
,
Nov 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4affc0751ef4ae3db46c06fa0f23049898f5a724 commit 4affc0751ef4ae3db46c06fa0f23049898f5a724 Author: Tom Anderson <thomasanderson@chromium.org> Date: Thu Nov 09 19:34:53 2017 Gtk: Fix window titlebar color when using dark theme Before: https://bugs.chromium.org/p/chromium/issues/detail?id=782980 After: https://bugs.chromium.org/p/chromium/issues/detail?id=782980#c1 BUG= 782980 R=erg@chromium.org TBR=msw@chromium.org Change-Id: I0f0bc6e29bb821215fffaa98ea56d50b3abcd72d Reviewed-on: https://chromium-review.googlesource.com/758633 Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Elliot Glaysher <erg@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#515244} [modify] https://crrev.com/4affc0751ef4ae3db46c06fa0f23049898f5a724/chrome/browser/ui/libgtkui/gtk_ui.cc [modify] https://crrev.com/4affc0751ef4ae3db46c06fa0f23049898f5a724/chrome/browser/ui/libgtkui/gtk_ui.h [modify] https://crrev.com/4affc0751ef4ae3db46c06fa0f23049898f5a724/ui/gfx/x/x11_atom_cache.cc [modify] https://crrev.com/4affc0751ef4ae3db46c06fa0f23049898f5a724/ui/views/linux_ui/linux_ui.h [modify] https://crrev.com/4affc0751ef4ae3db46c06fa0f23049898f5a724/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
,
Nov 9 2017
,
Nov 10 2017
Verified this fix on the latest canary 64.0.3264.0 on Ubuntu 14.04. Can observe that the windows title bars are dark when using GTK dark theme on chrome. Attached is the screen shot for reference. Hence adding the TE-Verified labels. Thanks.. |
|||
►
Sign in to add a comment |
|||
Comment 1 by thomasanderson@chromium.org
, Nov 9 2017252 KB
252 KB View Download