Removal of blacklisted extension still opens uninstall URL |
||||
Issue descriptionChrome Version: 62.0.3202.89 OS: macOS 10.12.6 Found by: vdedhia@ What steps will reproduce the problem? (1) Install an extension that runs chrome.runtime.setUninstallURL() (2) Blacklist the extension with ExtensionInstallBlacklist (3) Remove the extension from chrome://extensions What is the expected result? The uninstall URL isn't opened What happens instead? A new tab is opened and navigates to the uninstall URL Concern: If an extension has been added to the blacklist, it may be malware. Allowing the extension to open a URL of its choice on removal could put the user at risk.
,
Nov 8 2017
,
Nov 10 2017
Heh, yeah, that's bad. We should fix that. catmullings@, think this is something you could tackle?
,
Nov 27 2017
Is there any additional information we could provide that would help in fixing this?
,
Dec 4 2017
Thanks for the ping nrpeter@. No add'l info needed. I have started implementing a fix for this.
,
Dec 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e81f74c848669929cefd25c6ec199da00f331779 commit e81f74c848669929cefd25c6ec199da00f331779 Author: Catherine Mullings <catmullings@chromium.org> Date: Sat Dec 09 00:06:03 2017 Extensions: Do not open uninstall url for blacklisted extensions Bug: 782951 Change-Id: I6a56cd27f51f99a3422fbbf145a0d4f9246fc44e Reviewed-on: https://chromium-review.googlesource.com/816056 Commit-Queue: catmullings <catmullings@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#522929} [modify] https://crrev.com/e81f74c848669929cefd25c6ec199da00f331779/extensions/browser/api/runtime/runtime_api.cc [modify] https://crrev.com/e81f74c848669929cefd25c6ec199da00f331779/extensions/browser/api/runtime/runtime_apitest.cc
,
Dec 9 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by nrpeter@chromium.org
, Nov 8 2017