New issue
Advanced search Search tips

Issue 782939 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

NGInlineLayoutAlgorithm container_fragment_builder direction is always kLtr

Project Member Reported by atotic@chromium.org, Nov 8 2017

Issue description

In NGInlineLayoutAlgorithm, the direction is always kLtr.

Abspos needs to know correct line direction in NGInlineLayoutAlgorithm::PositionLeadingItems.

This direction is unavailable inside PositionLeadingItems, because
it has not been computed yet.

In hallway chat, eae suggested that container_fragment should be initialized with the correct writing mode instead.

 

Comment 1 by kojii@chromium.org, Nov 9 2017

Cc: e...@chromium.org
Owner: ----
Status: Available
Sounds reasonable if there were code that need it.

We then need to change the "transform to physical" code to handle line-relative coordinate; i.e., transform by ignoring the direction in NGContainerFragmentBuilder.

Maybe we should introduce another geometry class for line-relative?
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 9

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix (was: Untriaged)

Sign in to add a comment