New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 782935 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 28 days ago
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: remove LiveSASS experiment

Project Member Reported by lushnikov@chromium.org, Nov 8 2017

Issue description

The LiveSASS experiment needs far more investment to bring it to the
reasonable status. The same (or even larger) investment will be required to support other languages.


 
A few outcomes:
- SourceMaps are unreliable, e.g. CSS post-processing breaks source maps (https://github.com/postcss/postcss/issues/797)
- SASS syntax supports variables as a part of property names, which partly breaks sourcemap generation

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ded3a7997dfb8307c761f4c38b627a398749f91

commit 4ded3a7997dfb8307c761f4c38b627a398749f91
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Thu Nov 09 07:50:33 2017

DevTools: kill LiveSASS experiment

This patch removes the LiveSASS experiment.

Bug:  782935 
Change-Id: Ic69058cb9e0dca6f4305f4730e6334ef67d344e7
Reviewed-on: https://chromium-review.googlesource.com/758752
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515119}
[modify] https://crrev.com/4ded3a7997dfb8307c761f4c38b627a398749f91/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-edit-insert-property-empty-rule.css
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-edit-insert-property-empty-rule.css.map
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-edit-insert-property-empty-rule.scss
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-edit-insert-property.css
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-edit-insert-property.css.map
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-edit-insert-property.scss
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-edit-remove-property.css
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-edit-remove-property.css.map
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-edit-remove-property.scss
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-edit-set-text.css
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-edit-set-text.css.map
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-edit-set-text.scss
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-edit-toggle-property.css
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-edit-toggle-property.css.map
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-edit-toggle-property.scss
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-mapping-bad.css
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-mapping-bad.css.map
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-mapping-bad.scss
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-mapping-good.css
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-mapping-good.css.map
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-mapping-good.scss
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-mapping-many-scss/_reset.scss
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-mapping-many-scss/base.css
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-mapping-many-scss/base.css.map
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-mapping-many-scss/base.scss
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-ssp-breaking-edits.css
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-ssp-breaking-edits.css.map
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-ssp-breaking-edits.scss
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-ssp-editing.css
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-ssp-editing.css.map
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/resources/test-ssp-editing.scss
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-css-1-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-css-1.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-css-2-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-css-2.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-css-3-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-css-3.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-diff-1-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-diff-1.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-editing-1-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-editing-1.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-editing-2-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-editing-2.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-scss-1-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-scss-1.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-scss-2-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-scss-2.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-scss-3-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-scss-3.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-scss-4-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-scss-4.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-scss-5-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-scss-5.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-scss-6-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-scss-6.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-scss-7-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ast-scss-7.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-edit-insert-property-empty-rule-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-edit-insert-property-empty-rule.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-edit-insert-property-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-edit-insert-property.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-edit-remove-property-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-edit-remove-property.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-edit-set-property-text-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-edit-set-property-text.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-edit-toggle-property-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-edit-toggle-property.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-find-node-for-position-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-find-node-for-position.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-mapping-bad-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-mapping-bad.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-mapping-good-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-mapping-good.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-mapping-many-scss-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-mapping-many-scss.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-mapping-with-cache-busting-url-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-mapping-with-cache-busting-url.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ssp-breaking-edits-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ssp-breaking-edits.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ssp-editing-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ssp-editing.html
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ssp-incremental-edit-invalid-value-expected.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/LayoutTests/http/tests/devtools/sass/test-ssp-incremental-edit-invalid-value.html
[modify] https://crrev.com/4ded3a7997dfb8307c761f4c38b627a398749f91/third_party/WebKit/Source/devtools/.eslintignore
[modify] https://crrev.com/4ded3a7997dfb8307c761f4c38b627a398749f91/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/4ded3a7997dfb8307c761f4c38b627a398749f91/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
[modify] https://crrev.com/4ded3a7997dfb8307c761f4c38b627a398749f91/third_party/WebKit/Source/devtools/front_end/externs.js
[modify] https://crrev.com/4ded3a7997dfb8307c761f4c38b627a398749f91/third_party/WebKit/Source/devtools/front_end/formatter_worker.json
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/Source/devtools/front_end/gonzales/MIT-LICENSE.txt
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/Source/devtools/front_end/gonzales/SCSSParser.js
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/Source/devtools/front_end/gonzales/gonzales-scss.js
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/Source/devtools/front_end/gonzales/module.json
[modify] https://crrev.com/4ded3a7997dfb8307c761f4c38b627a398749f91/third_party/WebKit/Source/devtools/front_end/inspector.json
[modify] https://crrev.com/4ded3a7997dfb8307c761f4c38b627a398749f91/third_party/WebKit/Source/devtools/front_end/integration_test_runner.json
[modify] https://crrev.com/4ded3a7997dfb8307c761f4c38b627a398749f91/third_party/WebKit/Source/devtools/front_end/main/Main.js
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/Source/devtools/front_end/sass/ASTService.js
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/Source/devtools/front_end/sass/ASTSourceMap.js
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/Source/devtools/front_end/sass/SASSProcessor.js
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/Source/devtools/front_end/sass/SASSSourceMapFactory.js
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/Source/devtools/front_end/sass/module.json
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/Source/devtools/front_end/sass_test_runner/SASSEditingTestRunner.js
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/Source/devtools/front_end/sass_test_runner/SASSTestRunner.js
[delete] https://crrev.com/3514a2f2db12ec03ec19276fa452ef408024bb80/third_party/WebKit/Source/devtools/front_end/sass_test_runner/module.json
[modify] https://crrev.com/4ded3a7997dfb8307c761f4c38b627a398749f91/third_party/WebKit/Source/devtools/scripts/extract_module/extract_module.js
[modify] https://crrev.com/4ded3a7997dfb8307c761f4c38b627a398749f91/third_party/WebKit/Source/devtools/scripts/namespaces.js

Status: Fixed (was: Assigned)

Comment 4 by yio...@gmail.com, Nov 17 2017

Why removed this function? Which is very useful for developers. The PostCSS problem should be solved by PostCSS itself, and the author also has plans to support it in the new version.
Is it possible to activate it in some way?

Sign in to add a comment