New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 782932 link

Starred by 1 user
Status: Assigned
Owner:
█ romax@chromium.org
Last visit > 30 days ago
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Improve naming of GetPagesRemovedOnCacheReset

Project Member Reported by romax@chromium.org, Nov 8 2017 
From the discussion in https://chromium-review.googlesource.com/c/chromium/src/+/752688, it seems there are some spaces to improve the naming of *RemovedOnCacheReset.
Maybe we can find a better name to replace this and have the names changed from the following places:
- OfflinePageClientPolicy
- ClientPolicyController
- Tasks in model/
- Taskified model.

The link to the comment: https://chromium-review.googlesource.com/c/chromium/src/+/752688/3/components/offline_pages/core/model/offline_page_model_taskified.cc#193
and the following comment on the same file at line 200.

Comment 1 by fgor...@chromium.org, Nov 15 2017

Labels: OS-Android
Owner: romax@chromium.org
Status: Available (was: Untriaged)
Could you please link to the comments discussing that? (at least patch number and file)

Comment 2 by romax@chromium.org, Nov 15 2017

Description: Show this description

Comment 3 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Available)

Comment 4 by chili@chromium.org, Aug 17 

Proposal for fixit:

GetPagesRemovedOnCacheReset -> GetNonPermanentPages?
GetPagesSupportedByDownload -> GetPagesShownOnDownload?
►

Sign in to add a comment