New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 782931 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1% regression in memory metrics for media.desktop at 514099:514117

Project Member Reported by chcunningham@chromium.org, Nov 8 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=782931

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=4e2793dff44d49f119f67678790c24461c1cc4d52fdf69f4fe5eb29cdcc84a49


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-nvidia
Cc: lalitm@chromium.org
Owner: lalitm@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author lalitm@chromium.org ===

Hi lalitm@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Lalit Maganti
  Commit : 4abf070769524d3724daa8d467710f8df24202fe
  Date   : Mon Nov 06 12:35:32 2017
  Subject: memory-infra: ensure that shared -> global edges have highest importance

Bisect Details
  Configuration: winx64nvidia_perf_bisect
  Benchmark    : media.desktop
  Metric       : memory:chrome:all_processes:reported_by_chrome:cc:effective_size_avg/video.html?src_tulip2.ogg_type_audio_seek
  Change       : 1.44% | 12131512.5714 -> 12283649.7143

Revision             Result                   N
chromium@514098      12131513 +- 4660599      14      good
chromium@514108      12543453 +- 3169822      14      good
chromium@514113      12404059 +- 3089397      9       good
chromium@514114      12942911 +- 239304       6       bad       <--
chromium@514115      12546054 +- 3102345      9       bad
chromium@514117      12283650 +- 4583347      14      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=video.html.src.tulip2.ogg.type.audio.seek media.desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8963453563806961424


For feedback, file a bug with component Speed>Bisection
Cc: primiano@chromium.org ssid@chromium.org
Status: Started (was: Assigned)
My feeling is that the regression is actually the fixing of a bug with memory allocated to some other process being allocated to cc now that importance is correctly assigned.

primiano@, ssid@: thoughts?

Comment 5 by lalitm@chromium.org, Dec 13 2017

Status: WontFix (was: Started)
I believe my intuition in the previous comment is correct so closing this.

Sign in to add a comment