New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 782928 link

Starred by 1 user
Status: Fixed
Owner:
█ jcivelli@chromium.org
Last visit > 30 days ago
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 775677



Sign in to add a comment

MediaParser.mojom should be servicified

Project Member Reported by jcivelli@chromium.org, Nov 8 2017 
As part of the effort of removing UtilityprocessHost, MediaParser should be servicified and UtilityProcessMojoClient uses should be removed from:
chrome/browser/media_galleries/fileapi/safe_audio_video_checker.h
chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.h

Comment 1 by xhw...@chromium.org, Nov 9 2017 

Is there a bug for the "effort of removing UtilityprocessHost"?

Comment 2 by jcivelli@chromium.org, Nov 9 2017

Blocking: 775677
Yes, see 775677

Comment 3 by jcivelli@chromium.org, Nov 10 2017

Status: Fixed (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/069422f9fd3e8b4422c43816fd974d17fa5fc169

commit 069422f9fd3e8b4422c43816fd974d17fa5fc169
Author: Jay Civelli <jcivelli@google.com>
Date: Fri Nov 10 18:55:52 2017

Servifying MediaParser.mojom

As part of the effort to deprecate UtilityProcessMojoClient,
servicifying MediaParser.mojom and making SafeAudioVideoChecker and
SafeMediaMetaDataParser client libraries.

Bug:  782928 
Change-Id: I6357eadd9a1bc258b57d88b05d4aad21538cd6a2
Reviewed-on: https://chromium-review.googlesource.com/758750
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515614}
[modify] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/app/BUILD.gn
[modify] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/app/generated_resources.grd
[modify] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/browser/BUILD.gn
[modify] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/browser/DEPS
[modify] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
[delete] https://crrev.com/e55c9ef8290932dff7fa5851b0bbb459153c66e0/chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc
[delete] https://crrev.com/e55c9ef8290932dff7fa5851b0bbb459153c66e0/chrome/browser/media_galleries/fileapi/safe_audio_video_checker.h
[modify] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/browser/media_galleries/fileapi/supported_audio_video_checker.cc
[modify] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/browser/media_galleries/fileapi/supported_audio_video_checker.h
[modify] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/common/extensions/BUILD.gn
[delete] https://crrev.com/e55c9ef8290932dff7fa5851b0bbb459153c66e0/chrome/common/extensions/media_parser.typemap
[modify] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/common/extensions/typemaps.gni
[add] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/BUILD.gn
[add] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/DEPS
[add] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/OWNERS
[rename] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/ipc_data_source.cc
[rename] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/ipc_data_source.h
[add] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/manifest.json
[add] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/media_gallery_util_service.cc
[add] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/media_gallery_util_service.h
[rename] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/media_metadata_parser.cc
[rename] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/media_metadata_parser.h
[add] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/media_parser.cc
[add] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/media_parser.h
[add] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/public/cpp/BUILD.gn
[add] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/public/cpp/DEPS
[add] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/public/cpp/safe_audio_video_checker.cc
[add] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/public/cpp/safe_audio_video_checker.h
[rename] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/public/cpp/safe_media_metadata_parser.cc
[rename] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/public/cpp/safe_media_metadata_parser.h
[add] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/public/interfaces/BUILD.gn
[add] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/public/interfaces/OWNERS
[add] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/public/interfaces/constants.mojom
[rename] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/public/interfaces/media_parser.mojom
[add] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/public/interfaces/media_parser.typemap
[rename] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/public/interfaces/media_parser_struct_traits.cc
[rename] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/services/media_gallery_util/public/interfaces/media_parser_struct_traits.h
[modify] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/typemaps.gni
[modify] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/utility/BUILD.gn
[modify] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/utility/DEPS
[modify] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/069422f9fd3e8b4422c43816fd974d17fa5fc169/chrome/utility/extensions/extensions_handler.cc
[delete] https://crrev.com/e55c9ef8290932dff7fa5851b0bbb459153c66e0/chrome/utility/media_galleries/OWNERS
►

Sign in to add a comment