New issue
Advanced search Search tips

Issue 782916 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Mac: Bookmark button title has no trailing padding

Project Member Reported by lgrey@chromium.org, Nov 8 2017

Issue description

Same root cause as  Issue 782537 , but split off into a separate bug so visual changes can be evaluated.
 

Comment 1 by sdy@chromium.org, Nov 8 2017

Cc: -sdy@chromium.org
Owner: sdy@chromium.org

Comment 2 by sdy@chromium.org, Nov 8 2017

Summary: Mac: Bookmark button title has no trailing padding (was: Mac: Bookmark button title sometimes doesn't respect trailing padding)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6dd96ffb49cea709f1373d01e7e7e19307a886f

commit c6dd96ffb49cea709f1373d01e7e7e19307a886f
Author: Sidney San Martín <sdy@chromium.org>
Date: Wed Dec 20 21:52:43 2017

[Mac] Ensure bookmark button titles elide correctly in LTR.

Currently, when drawing the title of a bookmark button cell in LTR, the
width isn't set, and the default width sticks out slightly from the
trailing edge of the cell. This causes titles that are just slightly too
big to fit into the cell to be clipped to the edge of the button.

This change avoids separate code paths for LTR and RTL by laying out the
title for LTR, always, and then flipping it if necessary.

Bug:  782537 ,  782916 
Change-Id: I31624822c79e45152426f914d5fde70243ec0e40
Reviewed-on: https://chromium-review.googlesource.com/835128
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525477}
[modify] https://crrev.com/c6dd96ffb49cea709f1373d01e7e7e19307a886f/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm

Comment 4 by sdy@chromium.org, Dec 20 2017

Status: Fixed (was: Available)

Sign in to add a comment