New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 782912 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Fullscreen-in-tab video controls and remoting UI are very small

Project Member Reported by dbbrooks@chromium.org, Nov 8 2017

Issue description

Component Extension:  6417.1106.0.0					
Chrome: 64.0.3260.2					
OS: Win 8

*This does not occur on Mac. 
*This does not occur on Chrome 63.

What steps will reproduce the problem?
(1) Cast a tab with a vimeo video playing to Chromecast
(2) Fullscreen the video
(3) re-size the window a bit if you don't already notice the video controls are tiny.

What is the expected result? Video controls and remoting UI should be the same size as the video controls before fullscreen-in-tab was initiated. 

What happens instead? Video controls and remoting UI are tiny. See screenshots attached. 
 
actual_remoting_UI-regression.PNG
38.6 KB View Download
expected_remoting_UI_correct-size.PNG
20.2 KB View Download
actual_vimeo_video_controls-regression.PNG
275 KB View Download
expected_vimeo_video_controls.PNG
310 KB View Download

Comment 1 by m...@chromium.org, Nov 8 2017

Status: WontFix (was: Untriaged)
This is WAI, but maybe we should increase the font size on the remoting interstitial now. We can update that when we remove the disable button from the content.
I don't believe remoting changes the dimensions of media controls.  Are they the same size in fullscreen without remoting?

Comment 3 by amp@chromium.org, Nov 9 2017

This is related to my fs-in-tab resizing change.  Regardless of remoting or not, we will render the video (and controls) at the capture resolution (likely higher than the users current local view) and then scale it down (or up) to fit.  Making the local window larger will result in a bigger ui (as it wouldn't need to scale down in that case), but may not be possible depending on the local display.  Remoting moves the content, but the local ui is still scaled.


Comment 4 by m...@chromium.org, Nov 9 2017

The problem is that there's a max font size specified in the style of the interstitial. If we remove that, the text should enlargen to compensate for the downscaling.

Comment 5 by m...@chromium.org, Nov 9 2017

OIC... we're talking about the controls, not the font size. That's going to be web page specific. However, even if they're smaller, they are generally still perfectly usable.

Comment 6 by x...@chromium.org, Nov 21 2017

Cc: -cliffordcheng@chromium.org
Labels: -Pri-3 Pri-1
Owner: x...@chromium.org
Status: Started (was: WontFix)
Uploaded a CL for review to change the remoting interstitial font size proportional to the viewport: https://chromium-review.googlesource.com/c/chromium/src/+/780434. 
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/567acdead506ea4a8114a7e84920422eebde015d

commit 567acdead506ea4a8114a7e84920422eebde015d
Author: Xiangjun Zhang <xjz@chromium.org>
Date: Wed Nov 22 19:22:07 2017

Change the media remoting UI text size proportional to viewport size.

Previously the remoting UI text size was fixed to 13px. However, the
tab capture fullscreen UI makes the remoting interstitial being
rendered in a fullscreen viewport. And it is then downscaled to fit
into the browser window, which makes the texts look too small for small
window. This Cl changed the size proportional to viewport size to solve
the issue.

Bug:  782912 
Change-Id: I989f636f65b1a4c27304f9d22ad3996692fcc0e7
Reviewed-on: https://chromium-review.googlesource.com/780434
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518706}
[modify] https://crrev.com/567acdead506ea4a8114a7e84920422eebde015d/third_party/WebKit/Source/modules/media_controls/resources/legacyMediaControls.css

Comment 8 by x...@chromium.org, Nov 22 2017

Status: Fixed (was: Started)
The above patch fixed the remoting UI size issue, but not the size of media controller. Marked this issue as fixed since the media controller WAI per comment #1. 
Status: Assigned (was: Fixed)
The UI elements are now a bit misaligned, is that expected? See screenshot.
Screen Shot 2017-11-28 at 2.26.30 PM.png
82.9 KB View Download

Comment 10 by x...@chromium.org, Nov 28 2017

The disable button was removed. The change landed yesterday.
Status: Fixed (was: Assigned)
Ah, got it. Thanks

Sign in to add a comment