Can you show more complete failure/crash output?

Considering what we know about strtol() under ASan ( bug 782454 ), it’s possible that some of these may be failing because of internal use of crashpad::StringToNumber().

Here's the test logs. I haven't really investigated yet, just trying to file so the next sheriff knows why the bot is red.

The logs suggest this isn't string related and is more likely because ASan and crashpad's crash handlers interfere with each other.

Deleted: crashpad_tests.txt 84.4 KB

crashpad_tests.txt 84.4 KB View Download

Mac ASan also has one test failure in MachOImageAnnotationsReader.CrashModuleInitialization:
https://build.chromium.org/p/chromium.clang/builders/ToTMacASan%20tester/builds/57
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.clang%2FToTMacASan_tester%2F57%2F%2B%2Frecipes%2Fsteps%2Fcrashpad_tests%2F0%2Flogs%2FMachOImageAnnotationsReader.CrashModuleInitialization%2F0

I guess we don't run Mac ASan on the CQ or main waterfall?

Guess not.

It once worked, and we added a few #if defined(ADDRESS_SANITIZER) around tricky areas. The lack of symbolization on the bot makes it difficult to say what’s wrong.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e16a775e9e8a6133a074ec01b558ce17d2f93a7

commit 0e16a775e9e8a6133a074ec01b558ce17d2f93a7
Author: Reid Kleckner <rnk@google.com>
Date: Fri Nov 10 20:57:24 2017

Don't run crashpad_tests on Windows ASan bots

ASan violates too many of crashpad's assumptions for it to be worth
making these tests pass. Even though most crashpad tests pass with ASan
and we could disable the five or so failing tests under ASan, I suspect
that new crashpad tests are likely to not work under ASan. I'd rather
not have to disable crashpad tests upstream and roll it just to pacify
these Windows ASan bots.

We should re-enable these tests when we care about shipping ASan builds
to users and reporting ASan errors back through craspad. Whoever works
on that is going to want to work through these tests failures and add
new integration tests here.

Remove the previous string test exclusion now that we won't run these
tests.

R=hans@chromium.org, mark@chromium.org
TBR=dpranke@chromium.org

Bug:  782907 ,  782454 
Change-Id: I5ba89193a3bcf5017a5c087040f1b1679163c17b
Reviewed-on: https://chromium-review.googlesource.com/762380
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515676}
[modify] https://crrev.com/0e16a775e9e8a6133a074ec01b558ce17d2f93a7/build/secondary/third_party/crashpad/crashpad/util/BUILD.gn
[modify] https://crrev.com/0e16a775e9e8a6133a074ec01b558ce17d2f93a7/testing/buildbot/chromium.clang.json

 Issue 782454  has been merged into this issue.

I'm going to unassign and leave this open and add some people that might be interested in making this work.

Looks like thakis@ re-enabled them while attempting to reunify the sets of tests we run on the buildbots, and that un-did my disabling of crashpad_tests under asan.

In any case, we have a new bug for tracking this: issue 845011.