New issue
Advanced search Search tips

Issue 782879 link

Starred by 1 user
Status: Assigned
Owner:
bcwh...@chromium.org
Cc:
asvitk...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Record Persistent Metrics To The Bitter End

Project Member Reported by bcwh...@chromium.org, Nov 8 2017 
Currently, the cleanup of Chrome creates a log of unreported metrics and then deletes the persistent file.  This both slows down the shutdown of Chrome and leaves a portion of the process lifetime uncovered with regard to metrics.

1) Don't delete the persistent metrics file.  This will collect all metrics until the process actually exits to be reported by a future run of the browser.  Because persistent metrics files include a copy of the system profile, they'll be properly associated with the correct run.

2) Don't do the final log collection, trusting that a future run will collect everything and report it correctly.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b8966222ff9c1cb131d8195f4c84f3078f3873d

commit 9b8966222ff9c1cb131d8195f4c84f3078f3873d
Author: Brian White <bcwhite@chromium.org>
Date: Fri Nov 10 19:32:54 2017

Don't delete persistent metics file on exit.

The persistent metrics file is no longer uploaded during startup but
rather as a background task later on.  This means that there is no
penalty to leaving the file around after shutdown but it will allow
us to collect metrics up until the very exit of the process.

This is gated on a Finch experiment/feature for now.

Bug: 782879
Change-Id: Ia353bdcc28affc029da69445f87e3c7592632cd6
Reviewed-on: https://chromium-review.googlesource.com/761481
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515634}
[modify] https://crrev.com/9b8966222ff9c1cb131d8195f4c84f3078f3873d/chrome/browser/metrics/chrome_metrics_service_client.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa85f190a8942a819ca1aa54a67dc7abd512c96d

commit aa85f190a8942a819ca1aa54a67dc7abd512c96d
Author: Brian White <bcwhite@chromium.org>
Date: Tue Jan 02 20:04:11 2018

Always keep metrics files on shutdown.

Everything went well with the experiment so make it permanent.

Bug: 782879
Change-Id: I340fc590d994bac2e50f17b25890558430136365
Reviewed-on: https://chromium-review.googlesource.com/847417
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526526}
[modify] https://crrev.com/aa85f190a8942a819ca1aa54a67dc7abd512c96d/chrome/browser/metrics/chrome_metrics_service_client.cc
►

Sign in to add a comment