New issue
Advanced search Search tips

Issue 782865 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows
Pri: 1
Type: Bug
Proj-XR

Blocking:
issue 773882
issue 791130



Sign in to add a comment

Make VRViewerType metric cross-platform

Project Member Reported by billorr@chromium.org, Nov 8 2017

Issue description

VR metrics are mostly in the Android directory.  Much of that code is cross-platform, but just lives in the wrong location.  We should move it to a cross-platform location so it can be shared with Windows.
 
Blocking: 773882
Labels: -Pri-3 M-64 VR-Desktop Pri-1
Status: Assigned (was: Untriaged)
We should at least enable the VRViewerType metrics for Windows devices in M64.
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c5b9f7876f0b96bc0af38b197a81d6a93b22f5f

commit 2c5b9f7876f0b96bc0af38b197a81d6a93b22f5f
Author: Bill Orr <billorr@chromium.org>
Date: Thu Nov 30 23:43:20 2017

Make VRViewerType metric cross-platform

This change is a targetted fix to send the VRViewerType metric from
multiple locations - both keeping the existing Android-only location
in VrShellGl, and adding a new location in OpenVRDevice.

The two metrics will trigger when we enter VR through the respective
platform-specific VR entry points. These two entrypoints will be
reconciled in a subsequent change that moves more VR metrics to a
cross-platform location.

BUG= 782865 

Change-Id: I17505eaa9bdefccb275dba0f5863a248c78c5968
Reviewed-on: https://chromium-review.googlesource.com/798028
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520751}
[modify] https://crrev.com/2c5b9f7876f0b96bc0af38b197a81d6a93b22f5f/chrome/browser/android/vr_shell/vr_metrics_util.cc
[modify] https://crrev.com/2c5b9f7876f0b96bc0af38b197a81d6a93b22f5f/chrome/browser/android/vr_shell/vr_metrics_util.h
[modify] https://crrev.com/2c5b9f7876f0b96bc0af38b197a81d6a93b22f5f/device/vr/openvr/openvr_device.cc
[modify] https://crrev.com/2c5b9f7876f0b96bc0af38b197a81d6a93b22f5f/device/vr/vr_device.h
[modify] https://crrev.com/2c5b9f7876f0b96bc0af38b197a81d6a93b22f5f/tools/metrics/histograms/enums.xml

Blocking: 791130
Status: fixed (was: Started)
Summary: Make VRViewerType metric cross-platform (was: Move VR metrics to be cross-platform)
Labels: VR-metrics
Components: Internals>XR

Sign in to add a comment