New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 782864 link

Starred by 2 users
Status: Fixed
Owner:
dougarnett@chromium.org
Closed: Nov 2017
Cc:
ryansturm@chromium.org
█ hiroshi@google.com
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Previews InfoBar being shown falsely for http -> https page load

Project Member Reported by dougarnett@chromium.org, Nov 8 2017 
Repro: With Data Save enabled and fast network connection, load http://wikipedia.org and notice info bar shown with final url of https://www.wikipedia.org


This occurs against HEAD and expect was introduced by https://chromium-review.googlesource.com/c/chromium/src/+/751901
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d797c28e91da56835cf962e4a936194cdc23b31c

commit d797c28e91da56835cf962e4a936194cdc23b31c
Author: Doug Arnett <dougarnett@chromium.org>
Date: Thu Nov 09 19:00:32 2017

Reverts PreviewsInfoBarTabHelper to check response headers for LitePage


Bug:  782864 
Change-Id: I445d55f1a17b43b95850aaaf4a5e45237ae87d38
Reviewed-on: https://chromium-review.googlesource.com/759404
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515227}
[modify] https://crrev.com/d797c28e91da56835cf962e4a936194cdc23b31c/chrome/browser/previews/previews_infobar_tab_helper.cc
[modify] https://crrev.com/d797c28e91da56835cf962e4a936194cdc23b31c/chrome/browser/previews/previews_infobar_tab_helper_unittest.cc

Comment 2 by dougarnett@chromium.org, Nov 10 2017

Status: Fixed (was: Assigned)

Comment 3 by aska...@chromium.org, Nov 17 2017 

Issue 786574 has been merged into this issue.

Comment 4 by aska...@chromium.org, Nov 17 2017

Cc: hiroshi@google.com

Comment 5 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 6 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews
►

Sign in to add a comment