NoScript information not showing on chrome://interventions-internals |
|||||||||
Issue descriptionRight now no information related to NoScriptJS is being shown on chrome://interventions-internals, such as if NoScriptJS is enabled/disabled, or any decisions related to whether NoScriptJS should be served or not. Enable/Disable status can be inserted to the interventions page by modifying the InterventionsInternalsPageHandler:https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler.cc?type=cs&q=InterventionsInternalsPageHandler::GetPreviewsEnabled&l=101 Logs can be added to chrome://interventions-internals by using PreviewsLogger's LogMessage method: https://cs.chromium.org/chromium/src/components/previews/core/previews_logger.cc?type=cs&q=PreviewsLogger::LogMessage&sq=package:chromium&l=130
,
Nov 8 2017
,
Nov 10 2017
,
Nov 10 2017
It looks like we do already get log entries for NoScript for presenting PreviewsInfoBar and at least the decisions based on existing PreviewsEligibilityReasons. So addressing this bug might just be adding NoScript status and there is another bug for adding a another eligibility reason for not being whitelisted that should ensure it gets logged properly to internals page when it is added.
,
Nov 10 2017
,
Nov 10 2017
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec6beef7386cbea7402cde4df26d59c076219b60 commit ec6beef7386cbea7402cde4df26d59c076219b60 Author: Doug Arnett <dougarnett@chromium.org> Date: Fri Nov 10 20:47:54 2017 Adds new NoScript previews type enabled status to internals page Bug: 782860 Change-Id: I0f0fd341e4035ea0e1c777580ac263e39bbf61fc Reviewed-on: https://chromium-review.googlesource.com/764207 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#515670} [modify] https://crrev.com/ec6beef7386cbea7402cde4df26d59c076219b60/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler.cc [modify] https://crrev.com/ec6beef7386cbea7402cde4df26d59c076219b60/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler_unittest.cc
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58c0f05df06cfe592fea28304cdb68343c120339 commit 58c0f05df06cfe592fea28304cdb68343c120339 Author: Doug Arnett <dougarnett@chromium.org> Date: Thu Nov 16 03:45:55 2017 Adds eligibility reasons for NoScript preview Adds reason for not being whitelisted and also a new Allowed reason for when server optimization hints we not enabled and so not checked. Bug: 780859 , 782860 Change-Id: Idedd812f0331b3e32f271fbac7268b535100227a Reviewed-on: https://chromium-review.googlesource.com/764589 Reviewed-by: Ryan Sturm (OOO until 11/27) <ryansturm@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#516973} [modify] https://crrev.com/58c0f05df06cfe592fea28304cdb68343c120339/components/previews/content/previews_io_data.cc [modify] https://crrev.com/58c0f05df06cfe592fea28304cdb68343c120339/components/previews/content/previews_io_data_unittest.cc [modify] https://crrev.com/58c0f05df06cfe592fea28304cdb68343c120339/components/previews/core/previews_black_list.h [modify] https://crrev.com/58c0f05df06cfe592fea28304cdb68343c120339/components/previews/core/previews_logger.cc [modify] https://crrev.com/58c0f05df06cfe592fea28304cdb68343c120339/components/previews/core/previews_logger_unittest.cc [modify] https://crrev.com/58c0f05df06cfe592fea28304cdb68343c120339/tools/metrics/histograms/enums.xml [modify] https://crrev.com/58c0f05df06cfe592fea28304cdb68343c120339/tools/metrics/histograms/histograms.xml
,
Nov 20 2017
,
Dec 5 2017
,
Dec 5 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 Deleted