New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 782858 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Dec 2017
Cc:
█ junov@chromium.org
fmalita@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ref-test changed after removing call to MakeForLocalSpace

Project Member Reported by reed@google.com, Nov 8 2017 
To draw a picture at a fixed resolution, the old blink code used SkPictureImageFilter: MakeForLocalSpace(). This is relatively inefficient (it uses 2 buffers). The replacement code just used drawImage. However, there is a slight difference in 2 reference tests due to two diff surprises:
- cc image decoding machine forces kLow filterquality to kMedium
- imagefilters cannot internally use kMedium, and so devolve to kLow
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d769122cadd25526413093e3f9c4e408394857b8

commit d769122cadd25526413093e3f9c4e408394857b8
Author: Mike Reed <reed@google.com>
Date: Thu Nov 09 01:33:18 2017

PaintImage instead of pictureimagefilter_localspace

Bug:  782858 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: If4a5bc70f8a9eac788960abfb3e2b4db5eec2438
Reviewed-on: https://chromium-review.googlesource.com/755214
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515050}
[modify] https://crrev.com/d769122cadd25526413093e3f9c4e408394857b8/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/d769122cadd25526413093e3f9c4e408394857b8/third_party/WebKit/LayoutTests/platform/linux/virtual/display_list_2d_canvas/fast/canvas/canvas-composite-expected.png
[modify] https://crrev.com/d769122cadd25526413093e3f9c4e408394857b8/third_party/WebKit/LayoutTests/platform/linux/virtual/display_list_2d_canvas/fast/canvas/canvas-incremental-repaint-expected.png
[modify] https://crrev.com/d769122cadd25526413093e3f9c4e408394857b8/third_party/WebKit/LayoutTests/platform/linux/virtual/display_list_2d_canvas/fast/canvas/fillrect_gradient-expected.png
[modify] https://crrev.com/d769122cadd25526413093e3f9c4e408394857b8/third_party/WebKit/LayoutTests/platform/mac/virtual/display_list_2d_canvas/fast/canvas/canvas-composite-expected.png
[modify] https://crrev.com/d769122cadd25526413093e3f9c4e408394857b8/third_party/WebKit/LayoutTests/platform/mac/virtual/display_list_2d_canvas/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png
[modify] https://crrev.com/d769122cadd25526413093e3f9c4e408394857b8/third_party/WebKit/LayoutTests/platform/mac/virtual/display_list_2d_canvas/fast/canvas/canvas-incremental-repaint-expected.png
[modify] https://crrev.com/d769122cadd25526413093e3f9c4e408394857b8/third_party/WebKit/LayoutTests/platform/mac/virtual/display_list_2d_canvas/fast/canvas/fillrect_gradient-expected.png
[modify] https://crrev.com/d769122cadd25526413093e3f9c4e408394857b8/third_party/WebKit/LayoutTests/platform/win/virtual/display_list_2d_canvas/fast/canvas/canvas-composite-expected.png
[modify] https://crrev.com/d769122cadd25526413093e3f9c4e408394857b8/third_party/WebKit/LayoutTests/platform/win/virtual/display_list_2d_canvas/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png
[modify] https://crrev.com/d769122cadd25526413093e3f9c4e408394857b8/third_party/WebKit/LayoutTests/platform/win/virtual/display_list_2d_canvas/fast/canvas/canvas-incremental-repaint-expected.png
[modify] https://crrev.com/d769122cadd25526413093e3f9c4e408394857b8/third_party/WebKit/LayoutTests/platform/win/virtual/display_list_2d_canvas/fast/canvas/fillrect_gradient-expected.png
[delete] https://crrev.com/b129e85f23d020498c6181e48f8cfe97639e9590/third_party/WebKit/LayoutTests/virtual/display_list_2d_canvas/fast/canvas/canvas-arc-circumference-expected.png
[delete] https://crrev.com/b129e85f23d020498c6181e48f8cfe97639e9590/third_party/WebKit/LayoutTests/virtual/display_list_2d_canvas/fast/canvas/canvas-arc-circumference-fill-expected.png
[delete] https://crrev.com/b129e85f23d020498c6181e48f8cfe97639e9590/third_party/WebKit/LayoutTests/virtual/display_list_2d_canvas/fast/canvas/canvas-composite-transformclip-expected.png
[delete] https://crrev.com/b129e85f23d020498c6181e48f8cfe97639e9590/third_party/WebKit/LayoutTests/virtual/display_list_2d_canvas/fast/canvas/canvas-ellipse-circumference-expected.png
[delete] https://crrev.com/b129e85f23d020498c6181e48f8cfe97639e9590/third_party/WebKit/LayoutTests/virtual/display_list_2d_canvas/fast/canvas/canvas-ellipse-circumference-fill-expected.png
[modify] https://crrev.com/d769122cadd25526413093e3f9c4e408394857b8/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp

Comment 2 by dtapu...@chromium.org, Nov 9 2017

Components: Internals>Skia

Comment 3 by xlai@chromium.org, Dec 5 2017

Status: WontFix (was: Untriaged)
This issue is no longer relevant because display list 2d mode for html canvas is removed in https://bugs.chromium.org/p/chromium/issues/detail?id=776826.

Also, RecordingImageBufferSurface is going to be removed and then the call in GraphicsContext.cpp will become unreachable and might need to be removed too.
►

Sign in to add a comment