New issue
Advanced search Search tips

Issue 782841 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove content::RenderFrameHost* argument to DidInteractWithNonsecureCreditCardInput

Project Member Reported by elawrence@chromium.org, Nov 8 2017

Issue description

The RenderFrameHost pointer isn't used and not appropriate on iOS.
 
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddcbb682188337b198673e18c8b4703154238cde

commit ddcbb682188337b198673e18c8b4703154238cde
Author: Eric Lawrence <elawrence@chromium.org>
Date: Fri Nov 10 19:36:31 2017

Remove unneeded parameter in DidInteractWithNonsecureCreditCardInput

The DidInteractWithNonsecureCreditCardInput function currently expects
a content::RenderFrameHost* pointer, but implementers do not use this
parameter. Worse, that type should not be used on iOS (which does not
use classes inside /content). This CL removes the unneeded parameter
from the function.

Bug:  782841 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I99edb4497397f8f82b1b712667eb0dc98b107982
Reviewed-on: https://chromium-review.googlesource.com/759276
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515636}
[modify] https://crrev.com/ddcbb682188337b198673e18c8b4703154238cde/android_webview/browser/aw_autofill_client.cc
[modify] https://crrev.com/ddcbb682188337b198673e18c8b4703154238cde/android_webview/browser/aw_autofill_client.h
[modify] https://crrev.com/ddcbb682188337b198673e18c8b4703154238cde/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/ddcbb682188337b198673e18c8b4703154238cde/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/ddcbb682188337b198673e18c8b4703154238cde/components/autofill/content/browser/content_autofill_driver.cc
[modify] https://crrev.com/ddcbb682188337b198673e18c8b4703154238cde/components/autofill/content/browser/content_autofill_driver_unittest.cc
[modify] https://crrev.com/ddcbb682188337b198673e18c8b4703154238cde/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/ddcbb682188337b198673e18c8b4703154238cde/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/ddcbb682188337b198673e18c8b4703154238cde/components/autofill/core/browser/test_autofill_client.h
[modify] https://crrev.com/ddcbb682188337b198673e18c8b4703154238cde/components/autofill/ios/browser/autofill_client_ios.h
[modify] https://crrev.com/ddcbb682188337b198673e18c8b4703154238cde/components/autofill/ios/browser/autofill_client_ios.mm
[modify] https://crrev.com/ddcbb682188337b198673e18c8b4703154238cde/components/autofill/ios/browser/autofill_driver_ios.mm
[modify] https://crrev.com/ddcbb682188337b198673e18c8b4703154238cde/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h
[modify] https://crrev.com/ddcbb682188337b198673e18c8b4703154238cde/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm

Status: Fixed (was: Started)

Sign in to add a comment