Histogram update scripts no longer work due to missing argument |
||
Issue descriptionhttps://chromium.googlesource.com/chromium/src/+/d7690ddedbda1f141d1eb98bbd236ab192ecca8f introduced an additional argument to UpdateHistogramFromDict, which takes caller_script_name as part of the annotations. However, this fourth argument breaks the following scripts: update_gpu_driver_bug_workaround_entries.py update_net_error_codes.py update_use_counter_css.py
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4b941586ad6de249c8c371593a2ef9ccae90173 commit c4b941586ad6de249c8c371593a2ef9ccae90173 Author: Ryan Sleevi <rsleevi@chromium.org> Date: Wed Nov 08 22:47:33 2017 Update the net error code and GPU driver bug workaround histograms Update the network error codes and GPU driver bug workarounds for the current release. This also updates the scripts to pass in the calling script argument, introduced in d7690ddedbda1f141d1eb98bbd236ab192ecca8f BUG= 782837 Change-Id: Ia9f1dc7f9136b7419e85dafe395d0828fd4569fd Reviewed-on: https://chromium-review.googlesource.com/758933 Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#514980} [modify] https://crrev.com/c4b941586ad6de249c8c371593a2ef9ccae90173/tools/metrics/histograms/enums.xml [modify] https://crrev.com/c4b941586ad6de249c8c371593a2ef9ccae90173/tools/metrics/histograms/update_gpu_driver_bug_workaround_entries.py [modify] https://crrev.com/c4b941586ad6de249c8c371593a2ef9ccae90173/tools/metrics/histograms/update_net_error_codes.py
,
Nov 8 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by rsleevi@chromium.org
, Nov 8 2017