New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 782827 link

Starred by 1 user
Status: Fixed
Owner:
liber...@chromium.org
Closed: Nov 2017
Cc:
█ w...@chromium.org
tguilbert@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

is_frame_hidden isn't needed anymore for AVDA

Project Member Reported by liber...@chromium.org, Nov 8 2017 
AVDA used to get a "frame hidden" signal from WMPI, so that it could hide the overlay when the tab was was put into the background / closed.

however, this is now handled by AndroidOverlay internally.  If dialog_overlay_core is notified that the WebContents is hidden / destroyed / etc., then it sends an OverlayDestroyed message to the client.  AVDA / AVDACodecImage will already handle that properly.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/273128088e5cdee68dfe47a3a1b6173d17cef182

commit 273128088e5cdee68dfe47a3a1b6173d17cef182
Author: liberato@chromium.org <liberato@chromium.org>
Date: Thu Nov 09 18:08:48 2017

Remove is_frame_hidden from AVDA / SurfaceChooser.

AVDA used to receive a "frame hidden" signal from WMPI.  This would
let it give up the overlay in case some other frame needs it.

Now that DialogOverlayImpl destroys the overlay when the WebContents
is hidden / etc., this isn't needed.  It will be handled normally.

Bug:  782827 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9b5857f3b37545da2c44462de0424b00de8cb3ae
Reviewed-on: https://chromium-review.googlesource.com/759143
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515207}
[modify] https://crrev.com/273128088e5cdee68dfe47a3a1b6173d17cef182/media/base/ipc/media_param_traits_macros.h
[modify] https://crrev.com/273128088e5cdee68dfe47a3a1b6173d17cef182/media/base/overlay_info.h
[modify] https://crrev.com/273128088e5cdee68dfe47a3a1b6173d17cef182/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/273128088e5cdee68dfe47a3a1b6173d17cef182/media/gpu/android/android_video_decode_accelerator.cc
[modify] https://crrev.com/273128088e5cdee68dfe47a3a1b6173d17cef182/media/gpu/android/android_video_surface_chooser_impl.cc
[modify] https://crrev.com/273128088e5cdee68dfe47a3a1b6173d17cef182/media/gpu/android/android_video_surface_chooser_impl_unittest.cc
[modify] https://crrev.com/273128088e5cdee68dfe47a3a1b6173d17cef182/media/gpu/android/avda_picture_buffer_manager.cc
[modify] https://crrev.com/273128088e5cdee68dfe47a3a1b6173d17cef182/media/gpu/android/avda_picture_buffer_manager.h

Comment 2 by liber...@chromium.org, Nov 9 2017

Status: Fixed (was: Started)
►

Sign in to add a comment