New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 782796 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

clang-format quality problem

Project Member Reported by dtrainor@chromium.org, Nov 8 2017

Issue description

clang-format produced code that (choose all that apply): 
- Doesn't match Chromium style
- Riles my finely honed stylistic dander
- No sane human would ever choose

Here's the code before formatting:

doAnswer((invocation) -> { support.onDismiss(); return null; }).when(bubble).dismiss();

Here's the code after formatting:

doAnswer((invocation) -> {
    support.onDismiss();
    return null;
})
        .when(bubble)
        .dismiss();

Here's how it ought to look:

Not quite sure.  Maybe something like the following (or maybe the above is actually correct!).

doAnswer((invocation) -> {
    support.onDismiss();
    return null;
}).when(bubble).dismiss();


Code review link for full files/context:

 
Status: Assigned (was: Untriaged)
Owner: ----
Labels: clang-format
Labels: Pri-2
Setting defect without priority to Pri-2.
Status: Untriaged (was: Assigned)
Assigned, but no owner or component? Please find a component and/or owner

Sign in to add a comment