New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 782790 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 27
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 768586



Sign in to add a comment

clang-format quality problem - last "// clang-format on" in a file indents too much

Project Member Reported by dtrainor@chromium.org, Nov 8 2017

Issue description

clang-format produced code that (choose all that apply): 
- Doesn't match Chromium style
- Riles my finely honed stylistic dander
- No sane human would ever choose

Here's the code before formatting:

// clang-format off
// TODO( crbug.com/781018 ): Clang isn't formatting this correctly.
default @Nullable Pair<String, String> getLogs() {
    return null;
}
// clang-format on

Here's the code after formatting:

// clang-format off
// TODO( crbug.com/781018 ): Clang isn't formatting this correctly.
default @Nullable Pair<String, String> getLogs() {
    return null;
}
    // clang-format on

Here's how it ought to look:


// clang-format off
// TODO( crbug.com/781018 ): Clang isn't formatting this correctly.
default @Nullable Pair<String, String> getLogs() {
    return null;
}
// clang-format on
 
CL for some context: https://chromium-review.googlesource.com/c/chromium/src/+/726821 (look at FeedbackSource.java and FeedbackReporter.java).
Status: Assigned (was: Untriaged)
Owner: ----
Blockedon: 768586
Labels: clang-format
Status: Fixed (was: Assigned)
// clang-format off
// TODO(  crbug.com/781018  ): Clang isn't formatting this correctly.
default @Nullable Pair<String, String> getLogs() {
    return null;
}
// clang-format on

Sign in to add a comment