New issue
Advanced search Search tips

Issue 782780 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Discard RTT and throughput observations from non-GET requests

Project Member Reported by tbansal@chromium.org, Nov 8 2017

Issue description

Network Quality Estimator (NQE) current records RTT observations from all HTTP requests. However, non-GET requests (such as POST) may add noise to the network quality metrics since they may require longer processing times at the server. To reduce noise, NQE should record RTT observations from only the GET requests.

Similarly, in-flight non-GET requests should not be counted towards the threshold of NetworkQualityEstimatorParams::throughput_min_requests_in_flight() when taking the throughput observation.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c4f0cfe3fffbc4a8756867b5c7f6223ee5bc4ae

commit 6c4f0cfe3fffbc4a8756867b5c7f6223ee5bc4ae
Author: Tarun Bansal <tbansal@chromium.org>
Date: Thu Nov 09 02:17:48 2017

NQE: Discard RTT and throughput observations from non-GET requests

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Bug:  782780 
Change-Id: I419786e99fa6f794d5c84041f131254588328d9f
Reviewed-on: https://chromium-review.googlesource.com/758721
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515061}
[modify] https://crrev.com/6c4f0cfe3fffbc4a8756867b5c7f6223ee5bc4ae/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/6c4f0cfe3fffbc4a8756867b5c7f6223ee5bc4ae/net/nqe/throughput_analyzer.cc

Status: Fixed (was: Started)

Sign in to add a comment