New issue
Advanced search Search tips

Issue 782729 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

8.3%-97% regression in loading.desktop at 514117:514345

Project Member Reported by rmcilroy@chromium.org, Nov 8 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=782729

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=c3e563875fe35090f64be1763c4e0de9b827add32abe413211e4a5b33138be0c


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
chromium-rel-mac12
linux-release
๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/10686d56f80000
Cc: hirosh...@chromium.org japhet@chromium.org kouhei@chromium.org
Owner: japhet@chromium.org
Status: Assigned (was: Untriaged)
๐Ÿ“ Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/10686d56f80000

Make script cache hits async
By japhet@chromium.org ยท Mon Nov 06 23:47:59 2017
chromium @ 1aec1a92fb786cae0a24ff2b22d4858d4486252e

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
I think we need to revert this given the regression. :/
Hm.... :(
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1cfaee91ad08478fbd956fcd73d570032702397

commit e1cfaee91ad08478fbd956fcd73d570032702397
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Thu Nov 09 08:23:01 2017

Revert "Make script cache hits async"

This reverts commit 1aec1a92fb786cae0a24ff2b22d4858d4486252e.

Reason for revert: Regressing loading metrics
Bug:  782729 

Original change's description:
> Make script cache hits async
> 
> This CL also changes script cache hits to call
> ScriptResourceClient::NotifyAppendData, to fully emulate the normal
> loading process.
> 
> Bug: 237366
> Change-Id: I133326f87d3597593b954a5355e4783aa1debb81
> Reviewed-on: https://chromium-review.googlesource.com/737481
> Commit-Queue: Nate Chapin <japhet@chromium.org>
> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#514299}

TBR=hiroshige@chromium.org,japhet@chromium.org,ksakamoto@chromium.org,kouhei@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 237366
Change-Id: I0e7d10bb541aeed9e434c50b3803f7b4ad64298c
Reviewed-on: https://chromium-review.googlesource.com/759756
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515121}
[modify] https://crrev.com/e1cfaee91ad08478fbd956fcd73d570032702397/third_party/WebKit/LayoutTests/http/tests/security/subresourceIntegrity/clear-integrity-attribute-expected.txt
[modify] https://crrev.com/e1cfaee91ad08478fbd956fcd73d570032702397/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoaderTest.cpp
[modify] https://crrev.com/e1cfaee91ad08478fbd956fcd73d570032702397/third_party/WebKit/Source/core/loader/resource/ScriptResource.cpp
[modify] https://crrev.com/e1cfaee91ad08478fbd956fcd73d570032702397/third_party/WebKit/Source/platform/loader/fetch/Resource.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment