New issue
Advanced search Search tips

Issue 782718 link

Starred by 5 users

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.7%-12.7% regression in memory.desktop at 514257:514432

Project Member Reported by rmcilroy@chromium.org, Nov 8 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=782718

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=c96785c52dc59fce70926def4670fd390a4701eabc38f1d06e5baebbdf0dcd17


Bot(s) for this bug's original alert(s):

android-nexus5
android-nexus5X
android-webview-nexus5X
android-webview-nexus6
chromium-rel-mac12
chromium-rel-win10
Cc: verwa...@chromium.org
Owner: verwa...@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author verwaest@chromium.org ===

Hi verwaest@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Toon Verwaest
  Commit : 460652c9786c686094b71f9d64e3e6025252c11a
  Date   : Mon Nov 06 17:43:26 2017
  Subject: [ic] Migrate API getters to data handlers

Bisect Details
  Configuration: winx64_10_perf_bisect
  Benchmark    : memory.desktop
  Metric       : memory:chrome:all_processes:reported_by_chrome:v8:effective_size_avg/TrivialScrollingPageSharedPageState
  Change       : 0.35% | 9289728.0 -> 9322496.0

Revision                           Result              N
chromium@514278                    9289728 +- 0.0      6      good
chromium@514326                    9289728 +- 0.0      6      good
chromium@514350                    9289728 +- 0.0      6      good
chromium@514362                    9289728 +- 0.0      6      good
chromium@514365                    9289728 +- 0.0      6      good
chromium@514367                    9289728 +- 0.0      6      good
chromium@514367,v8@2d12bc5bae      9289728 +- 0.0      6      good
chromium@514367,v8@dfd029b45e      9289728 +- 0.0      6      good
chromium@514367,v8@c7ad5652d3      9289728 +- 0.0      6      good
chromium@514367,v8@460652c978      9322496 +- 0.0      6      bad       <--
chromium@514368                    9322496 +- 0.0      6      bad
chromium@514374                    9322496 +- 0.0      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=TrivialScrollingPageSharedPageState memory.desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8963477362138595072


For feedback, file a bug with component Speed>Bisection
Status: WontFix (was: Assigned)
This CL reduces memory usage since we replace full code objects with a smaller data structure encoding similar information. It's just looking like a regression on the average metrics since there are other heuristics involved.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Nov 16 2017

 Issue 785719  has been merged into this issue.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Nov 20 2017

Cc: tebbi@chromium.org
 Issue 786912  has been merged into this issue.
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Nov 21 2017

Cc: u...@chromium.org
 Issue 787435  has been merged into this issue.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Nov 22 2017

Issue 787429 has been merged into this issue.

Sign in to add a comment