New issue
Advanced search Search tips

Issue 782715 link

Starred by 3 users
Status: Fixed
Owner: ----
Closed: Mar 2018
Cc:
jongkwon...@navercorp.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 671916



Sign in to add a comment

[MacViewsBrowser] Incorrect focus handling

Reported by yama...@yandex-team.ru, Nov 8 2017 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.113 YaBrowser/17.9.1.888 Yowser/2.5 Safari/537.36

Steps to reproduce the problem:
There are some bugs with focus on MacViewsBrowser

1. Open ya.ru  - try by pressing "TAB"s move focus to location_bar - it's never go to it and always on wep_page elements.

2.  Open 2 tabs, on first tab open find_bar and focus it, select tab2 then tab1 - focus must be saved in find_bar.

What is the expected behavior?

What went wrong?
Store/Restore/Take focus don't work for MacViewsBrowser.

Did this work before? N/A 

Chrome version: 60.0.3112.113  Channel: n/a
OS Version: OS X 10.12.4
Flash Version: Shockwave Flash 27.0 r0

Comment 1 by spqc...@chromium.org, Nov 8 2017

Labels: Proj-MacViews

Comment 2 by tapted@chromium.org, Nov 8 2017

Blocking: 671916
Cc: jongkwon...@navercorp.com
This might be a thing that needs to be done in chrome_web_content_view_delegate_views_mac.mm . r494722 introduced that file. 

https://chromium-review.googlesource.com/c/chromium/src/+/668348 was following up with more stuff but it hasn't landed.

See also  Issue 710506 .

There might be a browser_test failing (if not, there should be one!)

Comment 3 by rkalavakuntla@chromium.org, Nov 10 2017

Labels: Needs-Milestone
Status: Untriaged (was: Unconfirmed)
The above issue seems similar to  Issue 710506  and also respective dev added a blocking  issue 671916 . Hence, marking this issue as Untriaged for further update from dev.
Thanks!

Comment 4 by tapted@chromium.org, Nov 10 2017

Labels: -Needs-Milestone M-64
Status: Started (was: Untriaged)
https://chromium-review.googlesource.com/c/chromium/src/+/758401
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a926c4ff061d678f8f3d54008a7d37b39247c7a0

commit a926c4ff061d678f8f3d54008a7d37b39247c7a0
Author: Maxim Podgorodskiy <yamaxim@yandex-team.ru>
Date: Mon Nov 20 02:06:39 2017

Fix web_contents focus handling.

On mac_views_browser fix bugs:
1. Return focus to location_bar throught "TAB"(key) pressing.
2. Saving focus on tabs(in tab_strip_model) swithing.
By handle associated methods in ChromeWebContentsViewDelegateViewsMac.

Make all focus changes in WebContentsView:
1. Move FocusThroughTabTraversal realization from WebContentsImpl to
WebContentsView.
2. Remove SetInitialFocus realizaton from WebContentsViewDelegate.

Reset stored focused view on any web_contens focus changing.

R=tapted@chromium.org

Bug:  782715 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I1ec95b655f7b5ee52fcc3a8cfea617a1ccab6f02
Reviewed-on: https://chromium-review.googlesource.com/758401
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517745}
[modify] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/chrome/browser/ui/browser_focus_uitest.cc
[modify] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.h
[modify] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm
[modify] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/chrome/browser/ui/views/find_bar_views_interactive_uitest.cc
[modify] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc
[modify] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.h
[modify] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views_mac.h
[modify] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views_mac.mm
[add] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_focus_helper.cc
[add] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_focus_helper.h
[modify] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/content/browser/web_contents/web_contents_view.h
[modify] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/content/browser/web_contents/web_contents_view_android.cc
[modify] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/content/browser/web_contents/web_contents_view_android.h
[modify] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/content/browser/web_contents/web_contents_view_aura.cc
[modify] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/content/browser/web_contents/web_contents_view_aura.h
[modify] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/content/browser/web_contents/web_contents_view_child_frame.cc
[modify] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/content/browser/web_contents/web_contents_view_child_frame.h
[modify] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/content/browser/web_contents/web_contents_view_guest.cc
[modify] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/content/browser/web_contents/web_contents_view_guest.h
[modify] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/content/browser/web_contents/web_contents_view_mac.h
[modify] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/content/browser/web_contents/web_contents_view_mac.mm
[modify] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/content/public/browser/web_contents_view_delegate.cc
[modify] https://crrev.com/a926c4ff061d678f8f3d54008a7d37b39247c7a0/content/public/browser/web_contents_view_delegate.h

Comment 6 by ellyjo...@chromium.org, Mar 23 2018

Status: Fixed (was: Started)
MacViews triage: this looks fixed by #5.
►

Sign in to add a comment