Issue metadata
Sign in to add a comment
|
Support individually-configurable UL element corner radii |
||||||||||||||||||||||||||
Issue descriptionThere are cases where having control over individual corners would benefit our UI. For example, the read-only URL bar (and possibly the URL input field) have buttons on the ends. Because the entire bar has rounded corners, the buttons themselves have only two rounded corners. We can draw this with Skia, or we could configure a simple Rect element to have 2 of its 4 corners rounded. Note that hit testing is also a concern here, and has to be handled in tandem with rendering. Assigning to Ian based on discussion, but, I can do this when time allows. Whoever gets to it first.
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2ac1860999d58d6743aa5f31ecc3de1178e79bc commit f2ac1860999d58d6743aa5f31ecc3de1178e79bc Author: Ian Vollick <vollick@chromium.org> Date: Thu Dec 14 17:14:21 2017 [vr] Add support for setting different corner radii for Rects With this change, rects can now have individually configurable corner radii. This does not apply to textured quads, and the utility for this is not as clear. (Also converts a few arguments to const refs and updates shadow to set the corner radius automatically). Bug: 782703 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id49a1cce69dc59178c1b4a8ce15df8f8016bf709 Reviewed-on: https://chromium-review.googlesource.com/827026 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#524094} [modify] https://crrev.com/f2ac1860999d58d6743aa5f31ecc3de1178e79bc/chrome/browser/vr/BUILD.gn [add] https://crrev.com/f2ac1860999d58d6743aa5f31ecc3de1178e79bc/chrome/browser/vr/elements/corner_radii.h [modify] https://crrev.com/f2ac1860999d58d6743aa5f31ecc3de1178e79bc/chrome/browser/vr/elements/full_screen_rect.cc [modify] https://crrev.com/f2ac1860999d58d6743aa5f31ecc3de1178e79bc/chrome/browser/vr/elements/rect.cc [modify] https://crrev.com/f2ac1860999d58d6743aa5f31ecc3de1178e79bc/chrome/browser/vr/elements/shadow.cc [modify] https://crrev.com/f2ac1860999d58d6743aa5f31ecc3de1178e79bc/chrome/browser/vr/elements/text.cc [modify] https://crrev.com/f2ac1860999d58d6743aa5f31ecc3de1178e79bc/chrome/browser/vr/elements/text.h [modify] https://crrev.com/f2ac1860999d58d6743aa5f31ecc3de1178e79bc/chrome/browser/vr/elements/text_input.cc [modify] https://crrev.com/f2ac1860999d58d6743aa5f31ecc3de1178e79bc/chrome/browser/vr/elements/text_input.h [modify] https://crrev.com/f2ac1860999d58d6743aa5f31ecc3de1178e79bc/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/f2ac1860999d58d6743aa5f31ecc3de1178e79bc/chrome/browser/vr/elements/ui_element.h [modify] https://crrev.com/f2ac1860999d58d6743aa5f31ecc3de1178e79bc/chrome/browser/vr/renderers/gradient_quad_renderer.cc [modify] https://crrev.com/f2ac1860999d58d6743aa5f31ecc3de1178e79bc/chrome/browser/vr/renderers/gradient_quad_renderer.h [modify] https://crrev.com/f2ac1860999d58d6743aa5f31ecc3de1178e79bc/chrome/browser/vr/test/fake_ui_element_renderer.cc [modify] https://crrev.com/f2ac1860999d58d6743aa5f31ecc3de1178e79bc/chrome/browser/vr/test/fake_ui_element_renderer.h [modify] https://crrev.com/f2ac1860999d58d6743aa5f31ecc3de1178e79bc/chrome/browser/vr/ui_element_renderer.cc [modify] https://crrev.com/f2ac1860999d58d6743aa5f31ecc3de1178e79bc/chrome/browser/vr/ui_element_renderer.h
,
Dec 14 2017
,
Feb 8 2018
|
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by vollick@chromium.org
, Nov 13 2017