Allow users to specify target domain and OU for domain join |
||||||||
Issue description
Don't assume domain = admin's domain who's joining the machine.
Also allow specifying CN=...,DN=... or whatever the syntax is for OU.
Maybe also add a field for extra config for Samba???
Consider UI choices:
Computer Name: [...]
Domain: [...]
OU (or whatever the path is called): [...]
Username: [...]
Password: [...]
or
Computer Name: [...]
Username: [...]
Password: [...]
[Advanced...] <-- adds extra fields
,
Nov 16 2017
,
Nov 16 2017
,
Nov 24 2017
Let's use "More options" per attached screenshot. When "More options" is clicked, it would show the other fields and the area becomes scrollable and would contain the additional fields "Domain" and "Organizational Unit". Does that make sense? What happens if the OU does not exist? Will one be created on the backend? Does samba properly parse error messages coming in otherwise?
,
Nov 24 2017
,
Nov 24 2017
It's fine. Out of curiosity, why is scrollbale not possible? Also, what is the placeholder for Domain and OU? Let's make sure we have the expected format clear there. For example, I wasn't aware that the separator should be comman and not slash.
,
Nov 24 2017
It's possible, but I doubt we do that as a general practice. Should "Next" button be scrolled as well? I don't think that's very convenient. Also it's harder to implement :)
,
Nov 24 2017
OK, that's fine!
,
Nov 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/system_api/+/9b6a22544458fc178095b3e9be90edfc6b0aa7ab commit 9b6a22544458fc178095b3e9be90edfc6b0aa7ab Author: Roman Sorokin <rsorokin@chromium.org> Date: Sat Nov 25 04:31:24 2017 system_api: Add new value and protos for authpolicy. Adds ERROR_CACHE_DEVICE_POLICY: needed to report to Chrome that device policy cached on authpolicy side. Adds protos for D-Bus function inputs. Needed to switch D-Bus calls to protobufs inputs. BUG= chromium:684679 , chromium:782695 TEST=none Change-Id: I35855edc781ad373007a8ef07e55f1e9f02f9016 Reviewed-on: https://chromium-review.googlesource.com/771630 Commit-Ready: Roman Sorokin <rsorokin@chromium.org> Tested-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> [modify] https://crrev.com/9b6a22544458fc178095b3e9be90edfc6b0aa7ab/dbus/authpolicy/active_directory_info.proto
,
Nov 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f377998aac728c4f6122ec47a540ede929fbfe05 commit f377998aac728c4f6122ec47a540ede929fbfe05 Author: Roman Sorokin <rsorokin@chromium.org> Date: Sat Nov 25 20:04:39 2017 Roll src/third_party/cros_system_api/ e46ef54fe..9b6a22544 (1 commit) https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/e46ef54fea48..9b6a22544458 $ git log e46ef54fe..9b6a22544 --date=short --no-merges --format='%ad %ae %s' 2017-11-15 rsorokin system_api: Add new value and protos for authpolicy. Created with: roll-dep src/third_party/cros_system_api BUG= chromium:684679 , chromium:782695 Change-Id: I7ed423a228670bc2673559ae0a908821c80e29fb Reviewed-on: https://chromium-review.googlesource.com/789850 Reviewed-by: Lutz Justen <ljusten@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#519186} [modify] https://crrev.com/f377998aac728c4f6122ec47a540ede929fbfe05/DEPS
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/system_api/+/e494ee7de6e2c99ede5683f0f78e07909f1ba2ed commit e494ee7de6e2c99ede5683f0f78e07909f1ba2ed Author: Lutz Justen <ljusten@chromium.org> Date: Tue Dec 05 16:51:42 2017 authpolicy: Add GetUserStatusRequest and OU errors Adds a parameter protobuf used for the GetUserStatus D-Bus call. Makes it easier in the future to modify parameters. Also adds errors in connection to setting the computer organizational unit (OU) during domain join. BUG= chromium:782695 TEST=Compiles Change-Id: Idccd265dce2324ce1928f0f8d184e6be06b3ba73 Reviewed-on: https://chromium-review.googlesource.com/803353 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> [modify] https://crrev.com/e494ee7de6e2c99ede5683f0f78e07909f1ba2ed/dbus/authpolicy/active_directory_info.proto
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0daf45e53731bd84a79f474248fe61ebf0114bb9 commit 0daf45e53731bd84a79f474248fe61ebf0114bb9 Author: Roman Sorokin <rsorokin@chromium.org> Date: Wed Dec 06 12:17:11 2017 Roll src/third_party/cros_system_api/ 5c4b60346..e494ee7de (1 commit) https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/5c4b603461a7..e494ee7de6e2 $ git log 5c4b60346..e494ee7de --date=short --no-merges --format='%ad %ae %s' 2017-12-01 ljusten authpolicy: Add GetUserStatusRequest and OU errors R=ljusten@chromium.org Created with: roll-dep src/third_party/cros_system_api BUG= chromium:782695 Change-Id: I14032dae5bcbd811fb9afa0561b2e6d4173167df Reviewed-on: https://chromium-review.googlesource.com/809112 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#522070} [modify] https://crrev.com/0daf45e53731bd84a79f474248fe61ebf0114bb9/DEPS
,
Dec 7 2017
,
Dec 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/887008d4f63eb0282e7f8125a138fd8a531dbb23 commit 887008d4f63eb0282e7f8125a138fd8a531dbb23 Author: Roman Sorokin <rsorokin@chromium.org> Date: Sat Dec 09 00:53:36 2017 Chromad: Allow users to specify target domain and OU During Active Directory domain join user could specify target domain and organizational units. Also now JoinAdDomain returns domain the machine was joined to. Fixed old tests to reflect that. Added some new tests. BUG= chromium:782695 TEST=new unittests and browsertests Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5351d176fe6298fab6aa6a1c6754d0f8321854ad Reviewed-on: https://chromium-review.googlesource.com/800618 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#522943} [modify] https://crrev.com/887008d4f63eb0282e7f8125a138fd8a531dbb23/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/887008d4f63eb0282e7f8125a138fd8a531dbb23/chrome/browser/chromeos/login/active_directory_login_browsertest.cc [modify] https://crrev.com/887008d4f63eb0282e7f8125a138fd8a531dbb23/chrome/browser/chromeos/login/enrollment/enrollment_screen.h [modify] https://crrev.com/887008d4f63eb0282e7f8125a138fd8a531dbb23/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc [modify] https://crrev.com/887008d4f63eb0282e7f8125a138fd8a531dbb23/chrome/browser/resources/chromeos/login/offline_ad_login.html [modify] https://crrev.com/887008d4f63eb0282e7f8125a138fd8a531dbb23/chrome/browser/resources/chromeos/login/offline_ad_login.js [modify] https://crrev.com/887008d4f63eb0282e7f8125a138fd8a531dbb23/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js [modify] https://crrev.com/887008d4f63eb0282e7f8125a138fd8a531dbb23/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc [modify] https://crrev.com/887008d4f63eb0282e7f8125a138fd8a531dbb23/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.h [modify] https://crrev.com/887008d4f63eb0282e7f8125a138fd8a531dbb23/chromeos/dbus/auth_policy_client.cc [modify] https://crrev.com/887008d4f63eb0282e7f8125a138fd8a531dbb23/chromeos/dbus/auth_policy_client.h [modify] https://crrev.com/887008d4f63eb0282e7f8125a138fd8a531dbb23/chromeos/dbus/fake_auth_policy_client.cc [modify] https://crrev.com/887008d4f63eb0282e7f8125a138fd8a531dbb23/chromeos/dbus/fake_auth_policy_client_unittest.cc [modify] https://crrev.com/887008d4f63eb0282e7f8125a138fd8a531dbb23/chromeos/login/auth/authpolicy_login_helper.cc [modify] https://crrev.com/887008d4f63eb0282e7f8125a138fd8a531dbb23/chromeos/login/auth/authpolicy_login_helper.h [modify] https://crrev.com/887008d4f63eb0282e7f8125a138fd8a531dbb23/chromeos/login/auth/authpolicy_login_helper_unittest.cc
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/eacfc0b5d9b830221542d1c2c5a76b0511314c54 commit eacfc0b5d9b830221542d1c2c5a76b0511314c54 Author: Lutz Justen <ljusten@chromium.org> Date: Wed Dec 13 20:33:37 2017 authpolicy: Fix issue with searching account info The -S <realm> parameter for net ads search was added to handle the case where the device realm doesn't match the user realm. However, this broke on a test lab (while it worked for another). Instead, use the user's smb.conf file, which contains the realm as well. This works in all cases, even though the device account used for authentication might belong to another domain (just needs trust between domains). BUG= chromium:782695 TEST=Manually on device TEST=test_that ... enterprise_AuthPolicyDaemonServer Change-Id: I2877facebb2cc8784135adf9cb1b56e46ad29039 Reviewed-on: https://chromium-review.googlesource.com/824264 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> [modify] https://crrev.com/eacfc0b5d9b830221542d1c2c5a76b0511314c54/authpolicy/samba_interface.cc
,
Jan 17 2018
,
Feb 5 2018
,
Feb 5 2018
Verified fixed. User is able to specify target domain and OU for domain join using "More options" dialog (see attached screenshots). Tested the following Computer OU combinations: OU=ChromeTEmtv OU=ChromeTEmtv,DC=chromeadm-lab,DC=com Chrome OS: 10323.12.0 Chrome: 65.0.3325.39 Device: Candy |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by rsorokin@chromium.org
, Nov 13 2017