New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 782689 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

--disable-translate command-line option was removed

Project Member Reported by pmeenan@chromium.org, Nov 8 2017

Issue description

A bunch of tooling depends on the --disable-translate command-line option to disable the translation suggestions from popping up.  It looks like it is no longer in the code, maybe from servicification efforts (haven't tracked down the point in history when it was removed).

A quick github search shows ~1700 references: https://github.com/search?q=%22--disable-translate%22&type=Code&utf8=%E2%9C%93

For WebPageTest specifically, this causes the translation dialog to pop up during performance testing which interferes both with screen shots and video-based performance measurements.

Is there a supported way to completely disable translate currently?
 
Cc: groby@chromium.org toyoshim@chromium.org
Looks like it was intentionally removed ~6 months ago with the recommended path to use policy list settings to disable translate: https://codereview.chromium.org/2819813002/

FWIW, there are probably a lot of downstream tools that automate production builds that are going to have issues as a result.  I can (and will) flip WebPageTest to use the policy list though I'm not sure that's an option on Android.
Sorry for inconvenience.

https://www.chromium.org/administrators/policy-list-3#TranslateEnabled
Since this document refers to Android specific different in some policies, I think the policy list works on Android, too.

I noticed that many applications depended on the flag, but also I wasn't sure how they really needed it today. Recently we stopped suggesting translate if the Google API Key wasn't baked-in. That means chromium variants should not be affected by this change because it already disabled the translate due to missing API key.

Then, this is the first report after ~6 months. So now I feel this wasn't critical for the most of such applications.

I agreed that using the flag was easier way to disable the translate, but the policy list may provide more abilities. WDYT?
Status: WontFix (was: Untriaged)
Looks like disabling it through prefs works so the policy list issues aren't as big of a deal.  On most platforms it also looks like it is hidden by one of the other command-line options (probably the one that disables infobars) and it's just the platforms that show the old message box that are having issues (Linux was the platform I was seeing it on).

Closing it out since there are workarounds that look to work well.

FWIW, most of the external tooling doesn't use chromium, it runs against the released Chrome browser and is used by dev's for testing their sites (functional or perf).  Appium, webdriver, lighthouse, WebPageTest and probably a bunch of others.  

I worked around it in WebPageTest but other tooling is also going to have to make changes as it pops up.

Sign in to add a comment