Replace cros_vm_lib.sh based bash scripts with chromite cros_vm |
||||
Issue descriptionWe have the following bash scripts: cros_start_vm cros_stop_vm cros_run_vm_test cros_run_vm_update cros_run_tast_vm_test These use cros_vm_lib.sh, cros_vm_constants.sh and a spaghetti of other scripts. We should replace them with chromite's cros_vm.py since the functionality is pretty close.
,
Nov 8 2017
there's also multiple chromite vm modules that need consolidating. but at least killing the shell scripts into one chromite python module would be an improvement.
,
Nov 15 2017
Also update image_to_vm.sh
,
Nov 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/2464e50aedc35c9b8fda021ccace1d12b4c463e7 commit 2464e50aedc35c9b8fda021ccace1d12b4c463e7 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Thu Nov 23 01:29:41 2017 [cros_vm]: Support for vlan. BUG=chromium:782664 TEST=manual Change-Id: I6e0ee1c4668bb58cfcaa0dde8c37450ecf6c52fa Reviewed-on: https://chromium-review.googlesource.com/780726 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/2464e50aedc35c9b8fda021ccace1d12b4c463e7/scripts/cros_vm.py
,
Dec 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/1297dcf5914bbd7dc9274938d74ff6ea3cfa50d1 commit 1297dcf5914bbd7dc9274938d74ff6ea3cfa50d1 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Fri Dec 08 11:59:10 2017 [cros_vm]: Support for detecting VM image path in chroot. * --board to supply board argument. * Make GetChromeLKGM a static method of SDKFetcher. * _SetVMImagePath looks for downloaded VM images in the SDK shell, and built VM images in the chroot. * _SetQemuPath for consistency. * Remove VM_IMAGE_PATH env var. BUG=chromium:782664 TEST=manual Change-Id: Ib659c2f66bc2a5c7444bd697b4ca0e3ab8036d30 Reviewed-on: https://chromium-review.googlesource.com/783271 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/1297dcf5914bbd7dc9274938d74ff6ea3cfa50d1/cli/cros/cros_chrome_sdk.py [modify] https://crrev.com/1297dcf5914bbd7dc9274938d74ff6ea3cfa50d1/scripts/cros_vm.py
,
Dec 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/6466cb9ef123453c5675bd61ba811b904d2b1487 commit 6466cb9ef123453c5675bd61ba811b904d2b1487 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Sat Dec 09 21:28:44 2017 [cros_run_vm_test]: Support for autotest. BUG=chromium:782664 TEST=cros_run_vm_test --board amd64-generic --autotest login_Cryptohome Change-Id: I3513c914a90e9e7eb7cb7dee7beaa3712fa656dd Reviewed-on: https://chromium-review.googlesource.com/794900 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/6466cb9ef123453c5675bd61ba811b904d2b1487/scripts/cros_run_vm_test.py
,
Jan 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/6c4fd2d5852758b31d6f7a16edfc08872aee769f commit 6c4fd2d5852758b31d6f7a16edfc08872aee769f Author: Achuith Bhandarkar <achuith@chromium.org> Date: Wed Jan 10 23:44:50 2018 [cros_vm]: Allow multiple tests. The following now work: cros_run_vm_test --autotest login_Cryptohome login_CryptohomeIncognito --board=amd64-generic cros_run_vm_test --catapult-tests testBrowserCreation testLoginStatus --board=amd64-generic BUG=chromium:782664 TEST=multiple autotests, multiple catapult tests Change-Id: I293d2418f9e57b51a51daa44aae479f3b0fa099c Reviewed-on: https://chromium-review.googlesource.com/857903 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/6c4fd2d5852758b31d6f7a16edfc08872aee769f/scripts/cros_run_vm_test.py
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/e7d564ab76aabb175fa5982691e3da2294e0d561 commit e7d564ab76aabb175fa5982691e3da2294e0d561 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Fri Jan 19 08:29:46 2018 [cros_vm]: Use separate directories for different ports. This allows us to launch multiple VMs with different ports. BUG=chromium:782664 TEST=Launch multiple VMs with different ports. Change-Id: I5a443d9d4e406a49d57e9ea8788fe42b7c4021e0 Reviewed-on: https://chromium-review.googlesource.com/871140 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/e7d564ab76aabb175fa5982691e3da2294e0d561/scripts/cros_vm.py
,
Jan 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crosutils/+/82f51ecb8bca78c702702561349708b1852e9943 commit 82f51ecb8bca78c702702561349708b1852e9943 Author: Nicolas Norvez <norvez@chromium.org> Date: Sat Jan 27 00:12:07 2018 image_to_vm: suggest the use of cros_vm Replace the outdated recommended command to start the VM. Don't use 'kvm', use chromite's 'cros_vm' instead. BUG=chromium:782664 TEST=check that the suggested command line is correct. Change-Id: I95b4e544b1d2d9c4d763747d910d54da562aaaa7 Reviewed-on: https://chromium-review.googlesource.com/889408 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Nicolas Norvez <norvez@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> [modify] https://crrev.com/82f51ecb8bca78c702702561349708b1852e9943/image_to_vm.sh
,
Jan 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crosutils/+/6c7947c9ec9ad8958234b11a2c8a2760deca2153 commit 6c7947c9ec9ad8958234b11a2c8a2760deca2153 Author: Nicolas Norvez <norvez@chromium.org> Date: Sat Jan 27 00:12:07 2018 cros_vm_constants: remove obsolete constants No CS hits for VMDK, VMX, VBOX constants. Last use of DEFAULT_MEM has also just been removed now that image_to_vm.sh recommends using cros_vm. BUG=chromium:782664 TEST=Looked up CS, Pre-CQ and CQ should confirm. Change-Id: Iaedd835c99db0033b6b72e606aa1225531fdd353 Reviewed-on: https://chromium-review.googlesource.com/889409 Commit-Ready: Nicolas Norvez <norvez@chromium.org> Tested-by: Nicolas Norvez <norvez@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> [modify] https://crrev.com/6c7947c9ec9ad8958234b11a2c8a2760deca2153/lib/cros_vm_constants.sh
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/be97748e5d6c06d51ccf2006e052935fd8c39ff3 commit be97748e5d6c06d51ccf2006e052935fd8c39ff3 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Wed Feb 07 08:43:55 2018 [cros_run_vm_test]: Fix typo in results_dir Also don't output kvm command twice. BUG=chromium:782664 TEST=manual Change-Id: I93e06b8e3a242727c82bdb66e322d43224e350cf Reviewed-on: https://chromium-review.googlesource.com/905814 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/be97748e5d6c06d51ccf2006e052935fd8c39ff3/scripts/cros_run_vm_test.py [modify] https://crrev.com/be97748e5d6c06d51ccf2006e052935fd8c39ff3/scripts/cros_vm.py
,
Feb 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/5776f192bd4745a0b3c316d71b1375241b0245ca commit 5776f192bd4745a0b3c316d71b1375241b0245ca Author: Achuith Bhandarkar <achuith@chromium.org> Date: Thu Feb 15 08:11:07 2018 [cros_vm]: Use autoninja instead. BUG=chromium:782664 TEST=--build Change-Id: Ifc64b539699f088b7726bb389a40b477a9815204 Reviewed-on: https://chromium-review.googlesource.com/919539 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/5776f192bd4745a0b3c316d71b1375241b0245ca/scripts/cros_run_vm_test.py
,
Feb 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/943fe7eb3012bd3c08c327ab08586f34c45d6d95 commit 943fe7eb3012bd3c08c327ab08586f34c45d6d95 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Fri Feb 23 11:36:57 2018 [cros_vm]: Use SDK version instead of LKGM for cache. If you enter the cros chrome SDK shell with --version, cros_vm --start doesn't work because we look up the SDK cache with lkgm instead of the SDK version. BUG=chromium:782664 TEST=enter cros chrome-sdk with --version 10428.0.0, launch cros_vm. Change-Id: Ia7e39ed992f33caa19bf66e7cd0fca38a23c6dae Reviewed-on: https://chromium-review.googlesource.com/932973 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/943fe7eb3012bd3c08c327ab08586f34c45d6d95/scripts/cros_vm.py
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/docs/+/d9e506a35757d0edd9a12f9fd837e5233e095985 commit d9e506a35757d0edd9a12f9fd837e5233e095985 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Fri Mar 02 08:12:04 2018 [cros_vm]: Update docs to use autoninja. * autoninja instead of specifying -j and -l * Don't need gn anymore since we automatically update args. BUG=chromium:782664 TEST=None Change-Id: I91076d583d39dd5bd69f2d28178f8263dba00162 Reviewed-on: https://chromium-review.googlesource.com/944512 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/d9e506a35757d0edd9a12f9fd837e5233e095985/cros_vm.md
,
Mar 5 2018
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/docs/+/d7f74aae5fec145be207ea915d1b63f8e65fc042 commit d7f74aae5fec145be207ea915d1b63f8e65fc042 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Thu Mar 08 03:47:01 2018 [cros_vm]: cros_run_vm_test documentation. * Documentation for running perf tests. * Additional documentation for launching cros_vm in chromeos * Documentation for running autotests. * Documentation for running arbitrary binary tests in simple chrome. BUG=chromium:782664 TEST=None Change-Id: I782cbd2c0dea053ed30205d76f61a975faf27146 Reviewed-on: https://chromium-review.googlesource.com/947152 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/d7f74aae5fec145be207ea915d1b63f8e65fc042/cros_vm.md
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/2beae2964d4125020810b0c05868bdb1fa721bbb commit 2beae2964d4125020810b0c05868bdb1fa721bbb Author: Achuith Bhandarkar <achuith@chromium.org> Date: Wed Mar 28 23:40:54 2018 cros_vm: Refactor argument parsing in cros_vm. We now use parents to combine the parsers of cros_vm and cros_run_vm_test. Previously, we used parse_known_args in cros_run_vm_test, and passed all unknown args to cros_vm. The help menu only displayed known args. * Use parents to combine argument parsing * Allow vm_dir to be specified on the command line. * device_addr is set to ssh://localhost:9222 BUG=chromium:782664 TEST=manual Change-Id: Ibdaf4ae87aec80fe879cefca133f14ccce21a7d7 Reviewed-on: https://chromium-review.googlesource.com/980806 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Benjamin Pastene <bpastene@chromium.org> [modify] https://crrev.com/2beae2964d4125020810b0c05868bdb1fa721bbb/scripts/cros_run_vm_test.py [modify] https://crrev.com/2beae2964d4125020810b0c05868bdb1fa721bbb/scripts/cros_vm.py
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/4e367c2f4075e425138f42caef1c44908b2bab55 commit 4e367c2f4075e425138f42caef1c44908b2bab55 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Wed Mar 28 23:40:59 2018 cros_vm: Fix crashes when board is not supplied. BUG=chromium:782664 TEST=manual Change-Id: I31beb075ddecbe9bd417740bcc59d800d52e1f2d Reviewed-on: https://chromium-review.googlesource.com/982743 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/4e367c2f4075e425138f42caef1c44908b2bab55/scripts/cros_vm.py
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/646431cd2652536a6b1e5556bbeb53704bb75225 commit 646431cd2652536a6b1e5556bbeb53704bb75225 Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Mar 29 02:44:54 2018 Roll src/third_party/chromite/ 3b2992430..4e367c2f4 (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/3b299243038c..4e367c2f4075 $ git log 3b2992430..4e367c2f4 --date=short --no-merges --format='%ad %ae %s' 2018-03-27 achuith cros_vm: Fix crashes when board is not supplied. 2018-03-26 achuith cros_vm: Refactor argument parsing in cros_vm. Created with: roll-dep src/third_party/chromite BUG=chromium:782664,chromium:782664 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Icfad6a5106689e7989b59bb8801d5ba12fd69fb3 Reviewed-on: https://chromium-review.googlesource.com/985122 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#546710} [modify] https://crrev.com/646431cd2652536a6b1e5556bbeb53704bb75225/DEPS
,
Apr 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/fd5d1859f1e087d96524f3c6be11272ec7c359a7 commit fd5d1859f1e087d96524f3c6be11272ec7c359a7 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Mon Apr 02 14:26:29 2018 cros_vm: Safely create vm_dir. There's a TOCTOU vulnerability raised here: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/871140#message-a810603ab6e1fc41752cc09937f370ec51765100 Introduce _CreateVMDir to fix this. BUG=chromium:782664 TEST=manual Change-Id: I1c22f2cd867ccd23d11974c4cef61b0673a3ce3a Reviewed-on: https://chromium-review.googlesource.com/980751 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> [modify] https://crrev.com/fd5d1859f1e087d96524f3c6be11272ec7c359a7/scripts/cros_vm.py
,
Apr 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db9d0142864e674168b0c1cf4a73256743480f9f commit db9d0142864e674168b0c1cf4a73256743480f9f Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Mon Apr 02 16:10:36 2018 Roll src/third_party/chromite/ 371913c4e..fd5d1859f (1 commit) https://chromium.googlesource.com/chromiumos/chromite.git/+log/371913c4e6f0..fd5d1859f1e0 $ git log 371913c4e..fd5d1859f --date=short --no-merges --format='%ad %ae %s' 2018-03-26 achuith cros_vm: Safely create vm_dir. Created with: roll-dep src/third_party/chromite BUG=chromium:782664 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I5e35d45bd91fd417ef123d40fcf3db5f9580469e Reviewed-on: https://chromium-review.googlesource.com/989845 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547443} [modify] https://crrev.com/db9d0142864e674168b0c1cf4a73256743480f9f/DEPS
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crostestutils/+/2b725fd122c700afca8b5c67ca8d370e9154f77e commit 2b725fd122c700afca8b5c67ca8d370e9154f77e Author: Achuith Bhandarkar <achuith@chromium.org> Date: Thu Jun 07 15:35:56 2018 devinstall_test: Use cros_vm instead. Use cros_vm instead of chromite/vm to remove a dependence on cros_start_vm. BUG=chromium:782664 TEST=Run devinstall_test.py CQ-DEPEND=CL:982819 Change-Id: I7fe665d5d0df8e5caef9ce5f3ec1369e1e56be88 Reviewed-on: https://chromium-review.googlesource.com/982748 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/2b725fd122c700afca8b5c67ca8d370e9154f77e/devmode-test/devinstall_test.py
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crostestutils/+/518c8e2fe6a188c555f0eebcb07a923f05f7f385 commit 518c8e2fe6a188c555f0eebcb07a923f05f7f385 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Fri Jun 08 19:43:24 2018 Revert "devinstall_test: Use cros_vm instead." This reverts commit 2b725fd122c700afca8b5c67ca8d370e9154f77e. Reason for revert: crbug.com/851073 Original change's description: > devinstall_test: Use cros_vm instead. > > Use cros_vm instead of chromite/vm to remove a dependence on > cros_start_vm. > > BUG=chromium:782664 > TEST=Run devinstall_test.py > CQ-DEPEND=CL:982819 > > Change-Id: I7fe665d5d0df8e5caef9ce5f3ec1369e1e56be88 > Reviewed-on: https://chromium-review.googlesource.com/982748 > Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> > Tested-by: Achuith Bhandarkar <achuith@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Bug: chromium:782664 Change-Id: I49e349148a2e47f71afa9373844bc7588288fb50 Reviewed-on: https://chromium-review.googlesource.com/1093276 Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Trybot-Ready: Achuith Bhandarkar <achuith@chromium.org> [modify] https://crrev.com/518c8e2fe6a188c555f0eebcb07a923f05f7f385/devmode-test/devinstall_test.py
,
Oct 12
,
Dec 18
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/7fdb6f49979923a1e87dd4b64dd3c93afdf0e8c1 commit 7fdb6f49979923a1e87dd4b64dd3c93afdf0e8c1 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Tue Dec 18 04:47:09 2018 cros_test: Autotests must run in chroot. if cros_run_vm_test --autotest is invoked outside chroot, enter chroot and fix up paths. BUG=chromium:782664 TEST=Manual Change-Id: I6fbdf0a75f900efa72cfb3da03ea478c28a9be3b Reviewed-on: https://chromium-review.googlesource.com/1381052 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Alex Zamorzaev <zamorzaev@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/7fdb6f49979923a1e87dd4b64dd3c93afdf0e8c1/lib/cros_test.py
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0fc57cce6ecfe36d3f7c8e654e561979f36f63e7 commit 0fc57cce6ecfe36d3f7c8e654e561979f36f63e7 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Wed Dec 19 05:33:30 2018 autotest: Update user-doc with cros_run_vm_test. BUG=chromium:782664 TEST=None Change-Id: Id4d9deeee4fc5044ea3b0e44571da4bf49358957 Reviewed-on: https://chromium-review.googlesource.com/1380597 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/0fc57cce6ecfe36d3f7c8e654e561979f36f63e7/docs/user-doc.md
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crostestutils/+/7653fcb8635b3661dd24b60ff0017a98bfbc1dfd commit 7653fcb8635b3661dd24b60ff0017a98bfbc1dfd Author: Achuith Bhandarkar <achuith@chromium.org> Date: Wed Dec 19 09:12:51 2018 vm_au_worker: Use cros_run_vm_test. Use cros_run_vm_test.py instead of the shell version. Invoke image_to_live.sh with cros_run_vm_test instead of cros_run_update. BUG=chromium:782664 TEST=amd64-generic-chromium-pfq Change-Id: I93fe0052d426eaf806dfed350cbfa56d5ce88f9f Reviewed-on: https://chromium-review.googlesource.com/1378794 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Alex Zamorzaev <zamorzaev@chromium.org> Reviewed-by: Alex Zamorzaev <zamorzaev@chromium.org> [modify] https://crrev.com/7653fcb8635b3661dd24b60ff0017a98bfbc1dfd/au_test_harness/vm_au_worker.py
,
Jan 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crostestutils/+/78010f7926958b1e84d33a885cef26777569dc1a commit 78010f7926958b1e84d33a885cef26777569dc1a Author: Achuith Bhandarkar <achuith@chromium.org> Date: Tue Jan 08 03:40:38 2019 devinstall_test: Use cros_vm instead. BUG=chromium:782664 TEST=src/platform/crostestutils/devmode-test/devinstall_test.py --verbose amd64-generic src/build/images/amd64-generic/latest/chromiumos_test_image.bin CQ-DEPEND=CL:1396259 Change-Id: If2cd4deef82a57236c392cab8568f81b80fdd867 Reviewed-on: https://chromium-review.googlesource.com/1395320 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Alex Zamorzaev <zamorzaev@chromium.org> [modify] https://crrev.com/78010f7926958b1e84d33a885cef26777569dc1a/devmode-test/devinstall_test.py
,
Jan 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/868258e043d4ad92c69efc791e9a307a9b763e61 commit 868258e043d4ad92c69efc791e9a307a9b763e61 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Tue Jan 08 03:40:34 2019 cros_vm: Start calls WaitForBoot. This allows scripts to interact with the VM immediately after cros_vm --start returns. BUG=chromium:782664 TEST=manual Change-Id: I17a061c2ba6d994b6df5caf128ef59e5f97748a8 Reviewed-on: https://chromium-review.googlesource.com/1396259 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: Alex Zamorzaev <zamorzaev@chromium.org> [modify] https://crrev.com/868258e043d4ad92c69efc791e9a307a9b763e61/lib/vm.py [modify] https://crrev.com/868258e043d4ad92c69efc791e9a307a9b763e61/lib/cros_test.py
,
Jan 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/075d206a32c2f9d59ae51bf6f5bb609ff7beeacb commit 075d206a32c2f9d59ae51bf6f5bb609ff7beeacb Author: Achuith Bhandarkar <achuith@chromium.org> Date: Tue Jan 08 03:40:34 2019 command_vm_test: Use cros_vm instead. BUG=chromium:782664 TEST=chromite/cli/cros/tests/cros_vm_test --board=amd64-generic --image_path=src/build/images/amd64-generic/latest/chromiumos_test_image.bin CQ-DEPEND=CL:1396259 Change-Id: Ia41bfaef23802a78fc36939009e645c0bb3b1095 Reviewed-on: https://chromium-review.googlesource.com/1396260 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Alex Zamorzaev <zamorzaev@chromium.org> [modify] https://crrev.com/075d206a32c2f9d59ae51bf6f5bb609ff7beeacb/cli/command_vm_test.py
,
Jan 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crosutils/+/c978b682a613f58144945bd97be1b126cc062094 commit c978b682a613f58144945bd97be1b126cc062094 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Tue Jan 08 09:59:08 2019 scripts: Remove unused scripts. Remove cros_run_vm_test and cros_run_vm_update. BUG=chromium:782664 TEST=bots Change-Id: Ia52d716cca7a21ef3a4b30d553ed8e71e70eff6b Reviewed-on: https://chromium-review.googlesource.com/1384578 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Alex Zamorzaev <zamorzaev@chromium.org> [delete] https://crrev.com/e7ed1a6967f12dd8d2e857bea094a92478cf0584/bin/cros_run_vm_update [delete] https://crrev.com/e7ed1a6967f12dd8d2e857bea094a92478cf0584/bin/cros_run_vm_test
,
Jan 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crostestutils/+/22353b5efd6ce18aa6ff1f612a58365c163e1518 commit 22353b5efd6ce18aa6ff1f612a58365c163e1518 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Tue Jan 08 09:59:08 2019 crostestutils: Remove unused scripts. Remove cros_run_vm_test and cros_run_vm_update. BUG=chromium:782664 TEST=bots CQ-DEPEND=CL:1384578 Change-Id: I629061900f5d569a402d65acb3c7c4de8b6cdf72 Reviewed-on: https://chromium-review.googlesource.com/1384820 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Alex Zamorzaev <zamorzaev@chromium.org> [delete] https://crrev.com/78010f7926958b1e84d33a885cef26777569dc1a/cros_run_vm_test [delete] https://crrev.com/78010f7926958b1e84d33a885cef26777569dc1a/cros_run_vm_update |
||||
►
Sign in to add a comment |
||||
Comment 1 by steve...@chromium.org
, Nov 8 2017Components: Infra>Client>ChromeOS
Labels: Hotlist-CrOS-Gardener hotlist-vm